This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Drop hyperkube image version > v1.17 #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcassany
previously approved these changes
Jul 30, 2020
jordimassaguerpla
previously approved these changes
Jul 30, 2020
We want to avoid situation when hyperkube will be dropped, when Kubernetes v1.17 will be updated second time.
mjura
dismissed stale reviews from jordimassaguerpla, davidcassany, and chentex
via
3ea5acc
|
Please review again, I have updated |
thehejik
approved these changes
Jul 31, 2020
chentex
approved these changes
Jul 31, 2020
evrardjp
added a commit
to evrardjp/skuba
that referenced
this pull request
Aug 6, 2020
Without this patch, hyperkube will be migrated from 1.17.4 to 1.17.x, which is not something we want. This is a re-implementation for backport reasons of the patch SUSE#1293.
evrardjp
added a commit
to evrardjp/skuba
that referenced
this pull request
Aug 12, 2020
Without this patch, hyperkube will be migrated from 1.17.4 to 1.17.x, which is not something we want. This is a re-implementation for backport reasons of the patch SUSE#1293.
evrardjp
added a commit
to evrardjp/skuba
that referenced
this pull request
Aug 13, 2020
Without this patch, hyperkube will be migrated from 1.17.4 to 1.17.x, which is not something we want. This is a re-implementation for backport reasons of the patch SUSE#1293.
mssola
added a commit
to mssola/skuba
that referenced
this pull request
Sep 21, 2020
Without this patch, hyperkube will be migrated from 1.17.4 to 1.17.x, which is not something we want. This is a re-implementation for backport reasons of the patch SUSE#1293 hyperkube migration Signed-off-by: Jean-Philippe Evrard <jean-philippe.evrard@suse.com> Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
This will improve check when exactly we have to drop hyperkube image during upgrade.
What does this PR do?
It will check what is current Kubernetes version and what is latest Kubernetes version.
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises: