This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Remove hyperkube migration #1313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
skuba-test shouldn't fail with this patch. The error is unrelated. |
evrardjp
force-pushed
the
fix-4.2.2-to-4.2.3
branch
from
1f355df to
96109d6
Compare
|
Rebased. |
Klaven
reviewed
Aug 12, 2020
Without this patch, hyperkube will be migrated from 1.17.4 to 1.17.x, which is not something we want. This is a re-implementation for backport reasons of the patch SUSE#1293.
evrardjp
force-pushed
the
fix-4.2.2-to-4.2.3
branch
from
96109d6 to
412b8d5
Compare
|
@Klaven rebased. |
|
I am not sure why this wasn't merged before renaming the branch, but someone should tackle this backport, else we'll be in real trouble soon, as we'll have multiple 1.17.x releases forward (which will all break because they rely on hyperkube and without this patch, hyperkube will be removed if upgrading from any 1.17.x to a higher version). |
|
@evrardjp Could you please reopen this PR against maintenance-caasp-v4.2 branch? Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, hyperkube will be migrated from 1.17.4 to
1.17.x, which is not something we want.
This is a re-implementation for backport reasons of the
patch #1293.
Why is this PR needed?
This prevents us for releasing a caasp v4.2+ (below 4.5) that would migrate away from hyperkube.
Partial-Fix https://github.com/SUSE/avant-garde/issues/1859
What does this PR do?
Remove hyperkube migration, which is only required in the skuba master/v5/v4.5 branch.
Anything else a reviewer needs to know?
Special test cases, manual steps, links to resources or anything else that could be helpful to the reviewer.
Info for QA
This is info for QA so that they can validate this. This is mandatory if this PR fixes a bug.
If this is a new feature, a good description in "What does this PR do" may be enough.
Related info
Info that can be relevant for QA:
Status BEFORE applying the patch
How can we reproduce the issue? How can we see this issue? Please provide the steps and the prove
this issue is not fixed.
Status AFTER applying the patch
How can we validate this issue is fixed? Please provide the steps and the prove this issue is fixed.
Docs
If docs need to be updated, please add a link to a PR to https://github.com/SUSE/doc-caasp.
At the time of creating the issue, this PR can be work in progress (set its title to [WIP]),
but the documentation needs to be finalized before the PR can be merged.
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises: