Fix compile issue introduced by nodejs change (increment node-pre-gyp version) #1034
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes compile issue caused by nodejs/node#21063 and mapbox/node-pre-gyp#391. See: mapbox/node-pre-gyp#408
|
Triggering CI again. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating node-pre-gyp to 0.11 fixes a compile error caused by nodejs/node#21063 and mapbox/node-pre-gyp#391. The issue irregularly occurs due to upstream changes to callbacks which, following a download failure, can cause duplicate callbacks which result in two builds of sqlite3 instead of one; the build consequently fails because the second build often removes files created by the first build. See: mapbox/node-pre-gyp#408