Fix issue with close event always being emitted
#408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a changed behaviour in Node 10, resulting from the fact that the `close` event is always being emitted now. This would have lead to the `place_binary()` callback being called twice when the HTTP request failed (with e.g. a 404). Refs: nodejs/node#21063 Fixes: mapbox#391
|
Thank you. Will tag a new release with this in a moment: v0.10.3 |
Actually, will be v0.11.0 |
subtly
added a commit
to subtly/node-sqlite3
that referenced
this pull request
Aug 29, 2018
Fixes compile issue caused by nodejs/node#21063 and mapbox/node-pre-gyp#391. See: mapbox/node-pre-gyp#408
hyj1991
pushed a commit
to X-Profiler/node-pre-gyp
that referenced
this pull request
Jun 16, 2023
Fix issue with `close` event always being emitted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a changed behaviour in Node 10, resulting
from the fact that the
closeevent is always being emittednow. This would have lead to the
place_binary()callback beingcalled twice when the HTTP request failed (with e.g. a 404).
Refs: nodejs/node#21063
Fixes: #391
Edit: The original breakage was reverted in Node 10.8.0 since it was an unintentional semver-major change, but will be kept for Node 11+.