Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fw_max_speed_fwd and /ubiquity_motor/fw_max_speed_rev to robot.yaml #199

Merged
merged 5 commits into from
Mar 25, 2022

Conversation

JanezCim
Copy link
Contributor

Solving https://github.com/UbiquityRobotics/pi_image2/issues/39

To test:

cd ~/catkin_ws/src/
git clone https://github.com/UbiquityRobotics/magni_robot.git -b feature-newrobotyaml-params
cd ~/catkin_ws/
catkin_make -j2
source devel/setup.bash

addfw_max_speed_fwd: 100 and fw_max_speed_rev: -100 into /etc/ubiquity/robot.yaml under ubiquity_motor:

ubiquity_motor:
  fw_max_speed_fwd: 100
  fw_max_speed_rev: -100

then

sudo systemctl restart magni-base.service

see if params have been set:

rosparam get /ubiquity_motor/fw_max_speed_fwd
rosparam get /ubiquity_motor/fw_max_speed_rev

@JanezCim JanezCim requested a review from mjstn March 21, 2022 11:49
JanezCim and others added 3 commits March 22, 2022 10:18

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@mjstn mjstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok now with 104

@JanezCim
Copy link
Contributor Author

I will merge this after we release beta2 image so we dont introduce new potential problems

@JanezCim JanezCim merged commit 1d2a965 into noetic-devel Mar 25, 2022
@JanezCim JanezCim deleted the feature-newrobotyaml-params branch March 25, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants