-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: embeddings #58
Merged
Merged
feat: embeddings #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmccloskey
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double check the notebooks for typos. The corrections can be added to a separate PR.
🎉 This PR is included in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For authors
Description
I have developed a set of codes for performing embedding using textual and protein sequences as a pair of examples on StarkQA-PrimeKG and BioBridge-PrimeKG dataset.
Following are several detailed key updates:
aiagents4pharma/talk2knowledgegraphs/utils/embeddings
, I included an abstract class ofEmbeddings
followed by a set of implementation classes ofEmbeddingWithSentenceTransformer
andEmbeddingWithHuggingFace
for embeddings.aiagents4pharma/talk2knowledgegraphs/tests/*
docs/notebooks/talk2knowledgegraphs/*
. In addition, I also included a tutorial for evaluating StarQA-PrimeKG with Vector Similarity Search (VSS) model using textual embeddings. Finally, there is a dedicated tutorial for multimodal embedding alignment tutorial using linear regression and neural network as examples.docs/talk2knowledgegraphs/*
.Note: There is an issue related to the sentence-transformer library that caused failing tests on macos-latest. For the time being, I set the tests on macOS-13 instead and opened a separate issue for this one at #59 .
Fixes #33
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests you conducted to verify your changes. These may involve creating new test scripts or updating existing ones.
tests
folderaiagents4pharma/talk2knowledgegraphs/tests/*
)Checklist
tests
folder) that prove my fix is effective or that my feature worksFor reviewers
Checklist pre-approval
Checklist post-approval
develop
intomain
? If so, please make sure to add a prefix (feat/fix/chore) and/or a suffix BREAKING CHANGE (if it's a major release) to your commit message.Checklist post-merge
develop
intomain
and is it suppose to run an automated release workflow (if applicable)? If so, please make sure to check under the "Actions" tab to see if the workflow has been initiated, and return later to verify that it has completed successfully.