Paragraph tags are stripped

[oandregal]

A gif is worth a thousand words:

Steps to repro:

• I created a reusable block to insert breadcrumbs on certain pages - a paragraph that contains a link and some other text.
• I reused that block in a page. The markup seemed to be correct in the editor.
• When I publish the page, the reusable block doesn't contain the paragraph markup.

[oandregal]

cc @noisysocks because I saw you did some work recently on reusable blocks.

[oandregal]

When I go back to the page to edit this I got this message:

And in the console:

[aduth]

I'm having trouble reproducing this. Do you have other plugins active on your site? Wondering if one of them may be clobbering the markup when the post is saved.

(Aside: The validation message looks backwards, should say "expected tag name p" I would think)

[oandregal]

I have 11 active plugins on my site (which is part of a WordPress network I manage):

• These are active at a network level: Akismet anti-spam, Blogger Importer, Categories to Tags Converter Importer, Force Strong Passwords, Jetpack by WordPress.com, Network Plugin Auditor, VaultPress, WordPress Importer.
• These are active on my site: Gutenberg, Official StatCounter Plugin, RSS Importer.

[oandregal]

I've got another way to reproduce this error, so perhaps it hasn't anything to do with ReusableBlocks. Here's the gif:

Steps:

• open an old published post that contains images and consecutive paragraphs
• convert to blocks
• publish

When I got back to the editor, the paragraph blocks cannot be processed by Gutenberg:

And this is what the console shows at that point:

The HTML that's saved looks like this (it contains the paragraph tags and some weird void paragraphs as well):

<!-- wp:core/paragraph -->
<p><em>» <a href="http://nosolosoftware.com/glossary/">Glossary</a> » Canonical model</em></p>
<!-- /wp:core/paragraph -->
<p>&nbsp;</p>
<!-- wp:core/paragraph -->
<p>It's known as the <a href="http://www.eaipatterns.com/CanonicalDataModel.html">canonical model</a> the model that contains the minimum number of elements required to communicate among programs or different parts of the same application:</p>
<!-- /wp:core/paragraph -->
<p>&nbsp;</p>
<!-- wp:core/image -->
<figure class="wp-block-image"><img src="http://nosolosoftware.com/files/2015/03/CanonicalDataModel.gif" alt="" /></figure>
<!-- /wp:core/image -->
<p>&nbsp;</p>
<!-- wp:core/paragraph -->
<p>Within Domain Driven Design there is a certain hesitance to use <a href="https://www.innoq.com/en/blog/thoughts-on-a-canonical-data-model/">a single canonical model for intercommunication</a>, leaning towards using microformats or <a href="http://martinfowler.com/bliki/MultipleCanonicalModels.html">multiple canonical models</a> depending on the <a href="http://martinfowler.com/bliki/BoundedContext.html">application context</a>:</p>
<!-- /wp:core/paragraph -->
<p>&nbsp;</p>
<!-- wp:core/image -->
<figure class="wp-block-image"><img src="http://nosolosoftware.com/files/2015/03/bounded_context.png" alt="" /></figure>
<!-- /wp:core/image -->

[oandregal]

I've tried deactivating Official StatCounter Plugin and RSS Importer and disconnecting Jetpack from my site as well. I've got the same result. Any other test I may do to help?

[aduth]

@nosolosw Can you try deactivating the Jetpack plugin instead of just disconnecting from WordPress.com?

[oandregal]

Yup, I did that as well (deactivating it at the network level) but got the same result.

[oandregal]

Confirmed that I can reproduce this in Gutenberg 2.0.

[withinboredom]

I also had this same problem, however my layout was a bit different:

<!-- wp:core/paragraph {"dropCap":true} -->
<p class="has-drop-cap">First Paragraph.</p>
<!-- /wp:core/paragraph -->

<!-- wp:core/paragraph -->

Second paragraph.

<!-- /wp:core/paragraph -->

All following paragraph blocks are missing <p> tags and were typed in the visual editor normally as writing a book. At the end, I added the drop cap to the first paragraph after editing the text in the block. Everything looked fine in the editor, however when I published, it was a massive block of text except for the first paragraph.

[withinboredom]

I should also add that I also had Jetpack connected, but disabling gutenberg resolved the problem.

[withinboredom]

I wonder if it has something to do with wpautop

[oandregal]

I can confirm that after @aduth #4874 I can only repro this with these steps if I have the Jetpack's "write post/pages in markdown" option enabled when I convert an old post to Gutenblocks.

Perhaps this is worth labeling Plugin / Extension conflict?

[Ipstenu]

Well... that’s a pretty big conflict. I had to disable Gutenberg just to get content written in Gutenberg to show correct. The only other option was manually editing OUT the Gutenberg html comments in html edit mode.

[aduth]

Relevant problematic code in Jetpack's Markdown module, removing paragraph tags on save:

https://github.com/Automattic/jetpack/blob/c5aea23/modules/markdown/easy-markdown.php#L547-L548
https://github.com/Automattic/jetpack/blob/c5aea23/_inc/lib/markdown/gfm.php#L278-L285

[aduth]

Since Jetpack's Markdown module strips paragraphs prior to save, merely deactivating the Markdown module will not retroactively fix broken posts. However, since Gutenberg is capable of "repairing" unwrapped paragraphs, it should† be resolved if opening the post once more and saving it within Gutenberg.

In trying this myself, this works as expected, with one exception being that link tags (and I assume may apply to bold, italic, etc) showed the HTML as escaped and needed to be updated before saving. Unsure yet if this is also a conflict introduced with Jetpack's Markdown module.

[mkaz]

@nosolosw @Ipstenu The Jetpack Markdown and Gutenberg conflict should be resolved in 2.3.0 which was deployed yesterday.

Fixed in this PR: #5288

[oandregal]

With Gutenberg 2.3.0 and Jetpack 5.8 it is no longer an issue (tested following this steps). 🎉

[aduth]

Great! Going to consider this closed unless the issue crops up again.