Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation: Fix tag name warning ordering #3956

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Validation: Fix tag name warning ordering #3956

merged 1 commit into from
Dec 13, 2017

Conversation

aduth
Copy link
Member

@aduth aduth commented Dec 12, 2017

See: #3922 (comment)

This pull request seeks to resolve an issue with incorrect ordering in the validation message for unexpected tag name. The ordering of the expected and actual names are reversed.

Testing instructions:

Change the <p> of a paragraph tag in post-content.js, then verify the validation console error reads correctly when navigating to Gutenberg > Demo.

  • Before: "Block validation: Expected tag name span, instead saw p."
  • After: "Block validation: Expected tag name p, instead saw span."

@aduth aduth added the Framework Issues related to broader framework topics, especially as it relates to javascript label Dec 12, 2017
@aduth aduth merged commit ee99ade into master Dec 13, 2017
@aduth aduth deleted the fix/validation-tag-name-order branch December 13, 2017 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

Assignees
No one assigned
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aduth @youknowriad