-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Simple View for video view on Android #16136
[RNMobile] Simple View for video view on Android #16136
Conversation
const { isSelected, style } = this.props; | ||
|
||
return ( | ||
<View style={ styles.videoContainer }> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Gutenberg Web, there is an option to set a poster for the video. Probably we can use that prop this.props.attributes.poster
and pass it here to show it as <ImageBackground>
so that users can see the poster instead of black view?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, that seems to be part of the extra block settings functionality though, to manually set a poster image. I can be wrong but, it doesn't seem useable for our case where we want to have a preview picture automatically shown, based on a frame from the video.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poster setting opened for public usage pretty recently, so I expect only a tiny amount of videos would come with a poster if any :(
What’s the status of this one? Is it still in active development? |
@hypest I think we can close this PR as it is not needed anymore? |
Closing as not relevant at this point. |
Description
Additional proposal on top of #16089 that demotes the in-block video preview to a simple
View
instead of the full react-native-video view. This is a temporary workaround until some issues with the view overflowing its boundaries are fixed.How has this been tested?
Tested using wordpress-mobile/gutenberg-mobile#1117
Types of changes
VideoPlayButton
component to render the play buttonvideo-player.android.js
to implement the Android side of the video component, rendering a simple View instead of the proper video preview.video-player.native.js
module intovideo-player.ios.js
to only hold the iOS side implementationChecklist: