-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Simple View for video view on Android #16136
Closed
hypest
wants to merge
1
commit into
rnmobile/open-video-by-browser-for-android
from
rnmobile/open-video-by-browser-for-android-simple-view
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
30 changes: 30 additions & 0 deletions
30
packages/block-library/src/video/video-play-button.native.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { Dashicon } from '@wordpress/components'; | ||
|
|
||
| /** | ||
| * External dependencies | ||
| */ | ||
| import { View, TouchableOpacity } from 'react-native'; | ||
|
|
||
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import styles from './video-player.scss'; | ||
|
|
||
| export default ( props ) => { | ||
| const { isSelected, onPressPlay, style } = props; | ||
|
|
||
| return ( | ||
| <TouchableOpacity disabled={ ! isSelected } onPress={ onPressPlay } style={ [ style, styles.overlay ] }> | ||
| <View style={ styles.playIcon }> | ||
| <Dashicon | ||
| icon={ 'controls-play' } | ||
| ariaPressed={ 'dashicon-active' } | ||
| size={ styles.playIcon.width } | ||
| /> | ||
| </View> | ||
| </TouchableOpacity> | ||
| ); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { Component } from '@wordpress/element'; | ||
| import { Dashicon } from '@wordpress/components'; | ||
| import { __ } from '@wordpress/i18n'; | ||
|
|
||
| /** | ||
| * External dependencies | ||
| */ | ||
| import { View, Linking, Alert } from 'react-native'; | ||
|
|
||
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import { default as VideoPlayButton } from './video-play-button'; | ||
| import styles from './video-player.scss'; | ||
|
|
||
| class Video extends Component { | ||
| constructor() { | ||
| super( ...arguments ); | ||
| this.onPressPlay = this.onPressPlay.bind( this ); | ||
| } | ||
|
|
||
| onPressPlay() { | ||
| const { source } = this.props; | ||
| if ( source && source.uri ) { | ||
| this.openURL( source.uri ); | ||
| } | ||
| } | ||
|
|
||
| // Tries opening the URL outside of the app | ||
| openURL( url ) { | ||
| Linking.canOpenURL( url ).then( ( supported ) => { | ||
| if ( ! supported ) { | ||
| Alert.alert( __( 'Problem opening the video' ), __( 'No application can handle this request. Please install a Web browser.' ) ); | ||
| window.console.warn( 'No application found that can open the video with URL: ' + url ); | ||
| } else { | ||
| return Linking.openURL( url ); | ||
| } | ||
| } ).catch( ( err ) => { | ||
| Alert.alert( __( 'Problem opening the video' ), __( 'An unknown error occurred. Please try again.' ) ); | ||
| window.console.error( 'An error occurred while opening the video URL: ' + url, err ); | ||
| } ); | ||
| } | ||
|
|
||
| render() { | ||
| const { isSelected, style } = this.props; | ||
|
|
||
| return ( | ||
| <View style={ styles.videoContainer }> | ||
| <View { ...this.props } /> | ||
| <VideoPlayButton | ||
| style={ style } | ||
| isSelected={ isSelected } | ||
| onPressPlay={ this.onPressPlay } | ||
| /> | ||
| </View> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| export default Video; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Gutenberg Web, there is an option to set a poster for the video. Probably we can use that prop
this.props.attributes.posterand pass it here to show it as<ImageBackground>so that users can see the poster instead of black view?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, that seems to be part of the extra block settings functionality though, to manually set a poster image. I can be wrong but, it doesn't seem useable for our case where we want to have a preview picture automatically shown, based on a frame from the video.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poster setting opened for public usage pretty recently, so I expect only a tiny amount of videos would come with a poster if any :(