Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added files for SPFx starter workflow #268

Closed
wants to merge 1 commit into from
Closed

Conversation

anoopt
Copy link

@anoopt anoopt commented Dec 16, 2019

SharePoint Framework (SPFx) starter workflow

This PR contains a starter workflow related to projects built using SharePoint Framework (SPFx). The workflow contains steps to build the project and create the package (.sppkg file) in the artifacts folder. Once there are actions related to deploying the package to SharePoint, the plan is submit a new PR with the same.

The following are satisfied as part of the PR.

  • Include a good description of the workflow.
  • Links to the language or tool will be nice (unless its really obvious)

In the workflow and properties files:

  • Includes a matching ci/properties/*.properties.json file.
  • Use title case for the names of workflows and steps, for example "Run tests".
  • The name of CI workflows should only be the name of the language or platform: for example "Go" (not "Go CI" or "Go Build")
  • Include comments in the workflow for any parts that are not obvious or could use clarification.
  • CI workflows should run push.
  • Packaging workflows should run on release with types: [created].

Some general notes:

  • Does not use an Action that isn't in the actions organization.
  • Does not send data to any 3rd party service except for the purposes of installing dependencies.
  • Does not use a paid service or product.

Copy link

@TheTrev409 TheTrev409 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green.

Copy link
Contributor

@andymckay andymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks ok, but we need to get approval from the logo holder, in this case Microsoft that we can use the Sharepoint logo. If you want to change it to another logo we can merge that. Otherwise we'll have to get that approval. And yes GitHub is now owned by Microsoft 😄 But we still need to do that work.

on:
push:
branches:
- master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- master
- $default-branch

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @andymckay . Sorry I do not think there a logo for SharePoint framework. So we have to go with the SharePoint logo. If not I can crop the SPFx part from this image.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to resolve the legal issue for that logo regardless I'm afraid.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. If there is anything that needs to be done from my side, please let me know.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know who to contact about the logo? Would you consider using a different logo, one that has a clear license?

Copy link
Author

@anoopt anoopt Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add the PnP SPFx logo and edit the starter workflow to include these PnP GitHub Actions

@github-actions
Copy link

This pull request has become stale and will be closed automatically within a period of time. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants