-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added files for SPFx starter workflow #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks ok, but we need to get approval from the logo holder, in this case Microsoft that we can use the Sharepoint logo. If you want to change it to another logo we can merge that. Otherwise we'll have to get that approval. And yes GitHub is now owned by Microsoft 😄 But we still need to do that work.
on: | ||
push: | ||
branches: | ||
- master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- master | |
- $default-branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @andymckay . Sorry I do not think there a logo for SharePoint framework. So we have to go with the SharePoint logo. If not I can crop the SPFx part from this image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to resolve the legal issue for that logo regardless I'm afraid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. If there is anything that needs to be done from my side, please let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know who to contact about the logo? Would you consider using a different logo, one that has a clear license?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add the PnP SPFx logo and edit the starter workflow to include these PnP GitHub Actions
This pull request has become stale and will be closed automatically within a period of time. Sorry about that. |
SharePoint Framework (SPFx) starter workflow
This PR contains a starter workflow related to projects built using SharePoint Framework (SPFx). The workflow contains steps to build the project and create the package (.sppkg file) in the artifacts folder. Once there are actions related to deploying the package to SharePoint, the plan is submit a new PR with the same.
The following are satisfied as part of the PR.
In the workflow and properties files:
ci/properties/*.properties.json
file.push
.release
withtypes: [created]
.Some general notes:
actions
organization.