-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added files for SPFx starter workflow #268
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"name": "SharePoint Framework (SPFx)", | ||
"description": "Build and package a SharePoint Framework project.", | ||
"iconName": "spfx", | ||
"categories": null | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
# This workflow will build a SharePoint Framework (SPFx) project and create the package in the artifacts, on every push to the master branch. | ||
# | ||
# To configure this workflow: | ||
# | ||
# Change the value of the environment variable SPPKG_FILE_NAME (below). | ||
|
||
name: SharePoint Framework (SPFx) | ||
|
||
on: | ||
push: | ||
branches: | ||
- master | ||
|
||
# Set the name of the sppkg file | ||
env: | ||
SPPKG_FILE_NAME: 'package-name.sppkg' # set this to the name of the sppkg file that gets generated (can be found in package-solution.json file) | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
node-version: [10.x] | ||
|
||
steps: | ||
# Checkout code | ||
- name: Checkout code | ||
uses: actions/checkout@v1 | ||
|
||
# Setup node.js runtime | ||
- name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
|
||
# npm install | ||
- name: Run npm install | ||
run: npm install | ||
|
||
# gulp bundle and package solution | ||
- name: Bundle and package | ||
run: | | ||
gulp bundle --ship | ||
gulp package-solution --ship | ||
|
||
# Upload artifacts (sppkg file) | ||
- name: Upload artifact (sppkg file) | ||
uses: actions/upload-artifact@v1.0.0 | ||
with: | ||
name: output | ||
path: sharepoint/solution/${{ env.SPPKG_FILE_NAME }} |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @andymckay . Sorry I do not think there a logo for SharePoint framework. So we have to go with the SharePoint logo. If not I can crop the SPFx part from this image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to resolve the legal issue for that logo regardless I'm afraid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. If there is anything that needs to be done from my side, please let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know who to contact about the logo? Would you consider using a different logo, one that has a clear license?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add the PnP SPFx logo and edit the starter workflow to include these PnP GitHub Actions