This repository was archived by the owner on Nov 24, 2022. It is now read-only.
Remove format from allowed attributes in schemas
#374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the attributes to use now format is deprecated.
Currently we allow two types of schemas: one with `format` and one with `document_type` and `schema_name`. We've done the work to remove usage of `format` so we can disable the first format. This doesn't completely remove the `oneOf` clause from the schemas because that is more involved (the tests rely heavily on this behaviour). This is the minimum we can do now to disallow `format` in publisher schemas. Follow up will remove the `oneOf` thing.
The `format` schema got removed. This updates the tests.
tijmenb
force-pushed
the
remove-format-from-oneof
branch
from
c7be56a to
ec01982
Compare
ikennaokpala
added a commit
to alphagov/smart-answers
that referenced
this pull request
Aug 17, 2016
Sequel to this PR (alphagov/govuk-content-schemas#374). I have made changes to the smart-answers FlowContentItem test. Updating it to conform to the recently updated son schema. Basically replacing format with schema name and introduction document_type. After this change. I have run the existing smart answer tests (regression, unit and flow) and all passed. No changes were recorded to the regression tests artefacts.
ikennaokpala
added a commit
to alphagov/smart-answers
that referenced
this pull request
Aug 17, 2016
Sequel to this PR (alphagov/govuk-content-schemas#374). I have made changes to the smart-answers FlowContentItem test. Updating it to conform to the recently updated JSON schema. Basically replacing format with schema name and introduction document_type. After this change. I have run the existing smart answer tests (regression, unit and flow) and all passed. No changes were recorded to the regression tests artefacts.
ikennaokpala
added a commit
to alphagov/smart-answers
that referenced
this pull request
Aug 17, 2016
Sequel to this PR (alphagov/govuk-content-schemas#374). I have made changes to the smart-answers FlowContentItem test. Updating it to conform to the recently updated JSON schema. Basically replacing format with schema name and introduction document_type. After this change. I have run the existing smart answer tests (regression, unit and flow) and all passed. No changes were recorded to the regression tests artefacts.
leenagupte
added a commit
to alphagov/calculators
that referenced
this pull request
Aug 17, 2016
The content schemas were modified in PR: alphagov/govuk-content-schemas#374 The content published by the calculators app has to conform to the updated schema.
This was referenced Aug 18, 2016
andrewgarner
added a commit
to alphagov/specialist-frontend
that referenced
this pull request
Aug 18, 2016
'format' has been replaced by 'document_type' and 'schema_name'. See alphagov/govuk-content-schemas#374
Merged
tijmenb
added a commit
that referenced
this pull request
Aug 31, 2016
This is a follow-up to #374. It removes the now-unnecessary nesting of the schema in a `oneOf`.
tijmenb
added a commit
that referenced
this pull request
Sep 1, 2016
This is a follow-up to #374. It removes the now-unnecessary nesting of the schema in a `oneOf`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we allow two types of schemas: one with
formatand one withdocument_typeandschema_name. We've done the work to remove usage offormatso we can disable the format schema.This doesn't completely remove the
oneOfclause from the schemas because that is more involved (the tests rely heavily on this behaviour). This is the minimum we can do now to disallowformatin publisher schemas. Follow up will remove theoneOfthing.Part of https://trello.com/c/mHIbkMDs