Conform smart-answer FlowContentItem to JSON schema update. #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikennaokpala
force-pushed
the
conform-smartanswers-json-schema
branch
from
ed4cd51 to
cafe97a
Compare
Sequel to this PR (alphagov/govuk-content-schemas#374). I have made changes to the smart-answers FlowContentItem test. Updating it to conform to the recently updated JSON schema. Basically replacing format with schema name and introduction document_type. After this change. I have run the existing smart answer tests (regression, unit and flow) and all passed. No changes were recorded to the regression tests artefacts.
ikennaokpala
force-pushed
the
conform-smartanswers-json-schema
branch
from
cafe97a to
dd1e454
Compare
|
Nice one @ikennaokpala 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Sequel to this PR (alphagov/govuk-content-schemas#374) by @tijmenb.
I have made the following changes to the smart-answers FlowContentItem test. Updating it to
conform to the recently updated JSON schema.
Basically replacing format with schema name and introduction document_type.
After this change. I have run the existing smart answer tests (regression, unit and flow) and all passed.
No changes were recorded to the regression tests artefacts.