Pass cohort name to universal analytics set dimension #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google's new universal analytics setDimension call takes 2 arguments: the dimension index and the custom data to set for this session. Our MultivariateTest still sends 4 arguments: the dimension index, the name of the test, the name of the cohort, and the scope in which to set these values. This set of arguments was the pattern for the old "classic" analytics component, but the new pattern discards the extra 2 arguments. This means we don't get any details of the cohort sent to the tracker. We don't need the 4th argument any more so we can discard that. We do want the cohort though, so we combine it with the name of the test and send that as the custom data for the dimension.
|
FWIW: I have tested this locally with the GA chrome debugger and it does send what I expect now. Showed it to Tim LB and he seemed happy with that as a test. |
|
Looks good to me 👍 |
sihugh
added a commit
that referenced
this pull request
Feb 17, 2016
…nalytics-set-dimension Pass cohort name to universal analytics set dimension
sihugh
deleted the
pass-cohort-name-to-universal-analytics-set-dimension
branch
This was referenced Feb 17, 2016
Merged
boffbowsh
pushed a commit
to alphagov/frontend
that referenced
this pull request
Jul 8, 2016
This pulls in a fix from govuk_frontend_toolkit that lives in 4.8.0 (see: alphagov/govuk_frontend_toolkit#251) but frontend currently uses 4.1.0. We don't feel comfortable bumping the dependency so we instead inline the method to get the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing of alphagov/smart-answers#2265 we noticed that only the test name was being sent to GA for our custom dimension where we expected to see the cohort name too. After a bit of digging we found that the
MultivariateTesthad not been updated since we removed the classic GA tracker analytics implementation. Old dimensions allowed 4 arguments: the dimension index, a name (this was the name of the test), a value (this was the name of the cohort), and a scope for the data to be set in (this was session scope); whereas new dimensions allow only 2 arguments: the dimension index and a piece of custom data (because all other arguments were ignored this was just the name of the test).We want to pass on the name of the cohort to the dimension so we change the call to set dimension from the
MultivariateTestto combine the test name and the cohort name and send this as the 2nd argument to the call.While we're at it we update the contact details for the person to communicate with about creating new custom dimensions as it's no longer Ashraf.
/cc @benilovj, @fofr