Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start now button abc tests #2282

Merged
merged 2 commits into from
Feb 19, 2016
Merged

Start now button abc tests #2282

merged 2 commits into from
Feb 19, 2016

Conversation

h-lame
Copy link
Contributor

@h-lame h-lame commented Feb 17, 2016

Re-do #2265 now that govuk_frontend_toolkit has been updated to communicate with GA correctly for multivariate tests using custom dimensions (see: alphagov/govuk_frontend_toolkit#251)

@h-lame h-lame force-pushed the start-now-button-abc-tests branch from 3b29de0 to 42431e9 Compare February 18, 2016 11:19
@erkde
Copy link
Contributor

erkde commented Feb 18, 2016

Once verified on integration or Heroku, and that the GA events are being sent, looks good to merge

@erkde erkde added the LGTM label Feb 18, 2016
@h-lame
Copy link
Contributor Author

h-lame commented Feb 18, 2016

Just verifying this on heroku (turns out GA is configured to collect from all traffic). Will leave alone for your deploy tomorrow and book something for Monday.

This lets us use the version of MultivariateTest that communicates with GA
correctly when using universal analytics and custom dimensions.
We want to run abc tests for three smart-answers on the text in the
"Start Now" button.  We're using both content experiments (configured the
contentExperimentId for the test and variantIds for each cohort) and a
custom dimension to track the data as this gives us total flexibility
for tracking things.
@h-lame h-lame force-pushed the start-now-button-abc-tests branch from 42431e9 to 46d9b4c Compare February 19, 2016 14:33
h-lame added a commit that referenced this pull request Feb 19, 2016
@h-lame h-lame merged commit c950be5 into master Feb 19, 2016
@h-lame h-lame deleted the start-now-button-abc-tests branch February 19, 2016 14:35
h-lame added a commit that referenced this pull request Mar 7, 2016
…ests"

This reverts commit c950be5, reversing
changes made to 5a1581d.

Note this isn't a clean revert as we've left in the Gemfile and Gemfile.lock changes to keep the govuk_frontend_toolkit upgrade.
h-lame added a commit that referenced this pull request Mar 8, 2016
…ests"

This reverts commit c950be5, reversing
changes made to 5a1581d.

Note this isn't a clean revert as we've left in the Gemfile and Gemfile.lock changes to keep the govuk_frontend_toolkit upgrade.
@ikennaokpala ikennaokpala restored the start-now-button-abc-tests branch July 12, 2016 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants