Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop abc test on start now buttons #2337

Merged
merged 1 commit into from
Mar 8, 2016

Conversation

h-lame
Copy link
Contributor

@h-lame h-lame commented Mar 7, 2016

Now that the abc test on start now buttons (see: #2282) has been running for a while we are ready to stop it.

This reverts commit c950be5, reversing
changes made to 5a1581d.

Note this isn't a clean revert as we've left in the Gemfile and Gemfile.lock changes to keep the govuk_frontend_toolkit upgrade.

This is for: https://trello.com/c/NaRemNDC/270-end-the-start-now-button-a-b-c-test

Do not merge/deploy until 8th March 2016.

@h-lame h-lame changed the title [DO NOT MERGE] Stop abc test on start now buttons [DO NOT MERGE (until 8/3/2016)] Stop abc test on start now buttons Mar 7, 2016
@h-lame
Copy link
Contributor Author

h-lame commented Mar 7, 2016

We now have a date: 8/3/2016 - we can merge after that.

@h-lame h-lame changed the title [DO NOT MERGE (until 8/3/2016)] Stop abc test on start now buttons Stop abc test on start now buttons Mar 7, 2016
@h-lame h-lame removed the Don't merge label Mar 7, 2016
@erkde
Copy link
Contributor

erkde commented Mar 7, 2016

This looks fine

@erkde erkde added the LGTM label Mar 7, 2016
@floehopper
Copy link
Contributor

You'd make me very happy if you rebased this against master before merging (assuming master has moved on in the meantime). We aim to do this with all our PRs.

…ests"

This reverts commit c950be5, reversing
changes made to 5a1581d.

Note this isn't a clean revert as we've left in the Gemfile and Gemfile.lock changes to keep the govuk_frontend_toolkit upgrade.
@h-lame h-lame force-pushed the stop-abc-test-for-start-now-buttons branch from 5ac7308 to 4dedd2d Compare March 8, 2016 11:19
h-lame added a commit that referenced this pull request Mar 8, 2016
…ttons

Stop abc test on start now buttons
@h-lame h-lame merged commit 3523346 into master Mar 8, 2016
@h-lame h-lame deleted the stop-abc-test-for-start-now-buttons branch March 8, 2016 13:38
davidbasalla added a commit that referenced this pull request Mar 29, 2016
This commit reverts #2337.
We ran a multivariate test for 'start now' buttons on 3 start pages in early March 2016. We want to run the test again to increase our confidence that the improvement trends shown in the original test are valid, with the same options winning and with a similar scale if difference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants