Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Portugal link to list of translators #2822

Merged
merged 3 commits into from
Nov 25, 2016

Conversation

chao-xian
Copy link
Contributor

@chao-xian chao-xian commented Nov 21, 2016

Supersedes #2802

Trello card

Register a death: Fix Portugal translators link

Description

Fix link on Register A Death that points to list of lawyers when it should be pointing to a list of translators.

Factcheck

Factcheck version

Expected changes

URL on GOV.UK

Before

https://www.gov.uk/register-a-death/y/overseas/portugal/in_the_uk

image

After

https://smart-answers-pr-2822.herokuapp.com/register-a-death/y/overseas/portugal/in_the_uk

image

@chao-xian chao-xian force-pushed the update-register-a-death-link branch 4 times, most recently from 7c32b0a to 2a3e37c Compare November 21, 2016 13:57
@chao-xian chao-xian added needs content review Waiting for a content designer to approve Ready for code review and removed Waiting on factcheck labels Nov 21, 2016
@ikennaokpala ikennaokpala added Passed code review and removed needs content review Waiting for a content designer to approve Ready for code review labels Nov 22, 2016
@ikennaokpala
Copy link
Contributor

ikennaokpala commented Nov 22, 2016

@kelvingan.. This LGTM 👍 .. the oru_result to north_korea_result switch may be related to #2820 #2807 #2806 @chao-xian

chao-xian and others added 3 commits November 25, 2016 10:57
Preparatory commit that generates all questions and responses for
Portugal. This will allow us to check if the forthcoming commits
contains the expected changes.
Preparatory commit that generates all questions and responses for
Portugal. This will allow us to check if the forthcoming commits
contains the expected changes.
@ikennaokpala ikennaokpala force-pushed the update-register-a-death-link branch from 2a3e37c to 84e595a Compare November 25, 2016 10:58
@ikennaokpala ikennaokpala merged commit 948a4cb into master Nov 25, 2016
@ikennaokpala ikennaokpala deleted the update-register-a-death-link branch November 25, 2016 11:01
leenagupte added a commit that referenced this pull request Nov 28, 2016
The regression tests were failing for Portugal in register-a-birth.

I think that when PR #2822 was rebased over PR #2820 the shared change
to the GRO text needed to be regenerated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants