Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail about playbook conditionals from changelog #423

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

oraNod
Copy link
Contributor

@oraNod oraNod commented Jun 4, 2024

This change manually includes details from the 2.17.0 changelog that were not included in the porting guide.

Relates to ansible/ansible-documentation#1523

This change manually includes details from the 2.17.0 changelog that
were not included in the porting guide.
@oraNod oraNod requested a review from felixfontein June 4, 2024 17:55
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be fixed in ansibe/ansible-documentation, not here.

Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I just saw it's already merged there.

@samccann
Copy link
Contributor

samccann commented Jun 4, 2024

Just curious - what happens to this manual patch when 10.1.0 is released? Will it still show up?

@felixfontein
Copy link
Contributor

It should stay, since by then this part is replaced by the part in ansible-documentation (either stable-2.17 branch or devel, I would have to check the code), and it's included in there as well.

@felixfontein felixfontein merged commit 6027fb5 into ansible-community:main Jun 4, 2024
5 checks passed
@felixfontein
Copy link
Contributor

@oraNod thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants