Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting Guide 2.17.0 adding assert details #1523

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

oraNod
Copy link
Contributor

@oraNod oraNod commented May 23, 2024

resolves #1491 This change brings details into the 2.17.0 porting guide that were mentioned in the changelog.

Once this is approved and merged, I'll create a corresponding PR for the build-data repo.

This change brings details into the 2.17.0 porting guide that were
mentioned in the changelog.
@oraNod oraNod added documentation Improvements or additions to documentation backport-2.17 Automatically create a backport for the stable-2.17 branch core_approval This PR requires approval from the Ansible Core team labels May 23, 2024
@oraNod oraNod requested a review from sivel May 23, 2024 08:29
@oraNod oraNod requested a review from samccann May 23, 2024 08:30
@oraNod
Copy link
Contributor Author

oraNod commented Jun 4, 2024

@samccann Hey, maybe this one slipped under the radar but we should probably try to get it in for the release, even if a bit delayed / late.

@samccann
Copy link
Contributor

samccann commented Jun 4, 2024

It requires core approval.. @sivel @bcoca - can you take a look?

@oraNod oraNod merged commit 4a1a54f into ansible:devel Jun 4, 2024
8 checks passed
Copy link

patchback bot commented Jun 4, 2024

Backport to stable-2.17: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.17/4a1a54f21c192da350d9ed462c721ba35d238803/pr-1523

Backported as #1561

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 4, 2024
Porting Guide 2.17.0 adding assert details

(cherry picked from commit 4a1a54f)
@oraNod
Copy link
Contributor Author

oraNod commented Jun 4, 2024

thanks @sivel

oraNod added a commit that referenced this pull request Jun 4, 2024
…/4a1a54f21c192da350d9ed462c721ba35d238803/pr-1523

[PR #1523/4a1a54f2 backport][stable-2.17] Porting Guide 2.17.0 adding assert details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.17 Automatically create a backport for the stable-2.17 branch core_approval This PR requires approval from the Ansible Core team documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 2.17.0 porting guide does not explain assert
3 participants