Empty search correct

[MilanPospisil]

Fixes AAH-820

Compound filter had problem that it accepted blank string (string with only empty spaces). This PR disables filter button in this situation. This corrects the issue for many containers that uses compound filter.

[ZitaNemeckova]

LGTM 👍

[himdel]

4.4 backport: #1376

[himdel]

@MilanPospisil can you please re-check if this works on master?

I think it doesn't:

(or am I testing the wrong thing?)

.. More specifically, I think the only difference on master is not being able to click the search button .. but it can still come from searching by pressing enter, and then from the url.

I think we need to handle at least:

• (done) searching by clicking should be disabled for empty search field (or one full of spaces)
• searching by enter should not work in empty search field (or one full of spaces)
• AppliedFilters should never show the empty keywords - it should act as if no filter was present, no Clear all filters either
• it should not affect the actual search results (I think this only works in collections now because every collection has a space somewhere in description)

Ideally we should clear ?keywords= and ?keywords=%20 from params (not just keywords, any such param),
and it should not be necessary to change AppliedFilters - we don't hide empty params there, we remove them before AppliedFilters renders them (but if it turns out you'd have to change every single container, hiding it in AppliedFilters might be better),
search params are expanded from params in every controller, so we also need to change that before a space lands there,
so I think the right place to fix this is ParamHelper.

[MilanPospisil]

@MilanPospisil can you please re-check if this works on master?

I think it doesn't:

(or am I testing the wrong thing?)

.. More specifically, I think the only difference on master is not being able to click the search button .. but it can still come from searching by pressing enter, and then from the url.

I think we need to handle at least:

* (done) searching by clicking should be disabled for empty search field (or one full of spaces)

* searching by enter should not work in empty search field (or one full of spaces)

* `AppliedFilters` should never show the empty keywords - it should act as if no filter was present, no Clear all filters either

* it should not affect the actual search results (I think this only works in collections now because every collection has a space somewhere in description)

Ideally we should clear ?keywords= and ?keywords=%20 from params (not just keywords, any such param), and it should not be necessary to change AppliedFilters - we don't hide empty params there, we remove them before AppliedFilters renders them (but if it turns out you'd have to change every single container, hiding it in AppliedFilters might be better), search params are expanded from params in every controller, so we also need to change that before a space lands there, so I think the right place to fix this is ParamHelper.

Ok, I did only button disable, I did forgot about enter and URL never come into my mind. I will create new PR and I will do it.

[MilanPospisil]

Solving this in:
#1402

[patchback]

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/ee0a93d1959343eae8e8b6f615ef3ba72e773bef/pr-1195

Backported as #1466

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.