Namespace list: use CompoundFilter & AppliedFilters instead of custom toolbar #1557
+68
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
force-pushed
the
namespace-search
branch
from
59d10bd to
0bce357
Compare
This comment has been minimized.
This comment has been minimized.
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Feb 2, 2022
… toolbar (ansible#1557) * Move our toolbar patternfly override to namespace-list, only used there now Issue: AAH-820 * Use CompoundFilter & AppliedFilters in namespace-list, instead of custom search * fix sort & Create alignment with multiline filter (cherry picked from commit 0bb6d90)
github-actions
bot
added
the
backported-4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AAH-820
AAH-820 was fixed in #1195 and #1402 for all screens using CompoundFilter, but NamespaceList wasn't using CompoundFilter yet (happened in #509 for the collection list screens).
This updates namespace list to use CompoundFilter and AppliedFilters, fixing the empty search issue, removing a custom label, and the page now also changes to 1 when filtering/sorting.
Before:
After: