Support repo-root-relative import paths #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to repo root
for both webpack and typescript, this aliases src/... to resolve in the actual src/ dir in the repo root.
This allows for imports like..
-import { UserType, UserAPI } from '../../api';
+import { UserType, UserAPI } from 'src/api';
regardless of the requiree location
cd src/
perl -i -npe 's/from '\''\.\./from '\''src/' */*.*
perl -i -npe 's/from '\''\.\.\/\.\./from '\''src/' */*/*.*
perl -i -npe 's/from '\''\.\.\/\.\.\/\.\./from '\''src/' */*/*/*.*
This was referenced Feb 7, 2023
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Feb 7, 2023
and clean up unused exports (ansible#3178, ansible#319)
himdel
added a commit
that referenced
this pull request
Feb 8, 2023
* Drop more insights-related code No-Issue * npm run imports-to-relative, find-unused-exports, imports-to-src and clean up unused exports (#3178, #319) * prettier: add plugin to sort imports sort external imports first, then src/, then any relative paths sort imports by source name, sort specifiers bump prettier to 2.8 ensure app.scss goes before patternfly.scss (#3198) * npm run prettier * sort index.ts exports perl -i -npe 's/^export/import/' src/**/index.ts npm run prettier perl -i -npe 's/^import/export/' src/**/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
resolve.aliasto the webpack config, andcompilerOptions.baseUrl+compilerOptions.pathsto tsconfig,allowing for JS/TS imports relative to the repository root (as long as they live under
src/).(The second commit just updates most imports, I skipped the
./ones and only changed the ones with../, can be trivially regenerated.)Cc @newswangerd , @ZitaNemeckova WDYT? :)
Does it make sense to go with
srcas the alias? It fits the path so it seems like a reasonable default,except there is a
srcnpm package (we don't depend on it, and it's related to redis, so, unlikely in frontend JS), so we may want to consider something a bit more exotic like^/srcor@/src?