Namespace detail - fix Sign all #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…paces/:namespace and update on route change, but only when matching or unset
make Sign all disabled when a repository is not selected, don't disable it when no collections are found (other filters may be in place), Issue: AAH-2308
github-actions
bot
added
backport-4.6
jerabekjiri
reviewed
Apr 27, 2023
| @@ -19,7 +19,8 @@ export function findDistroBasePathByRepo(distributions, repository) { | |||
| const distro = distributions.find( | |||
| (distro) => distro.name === repository.name, | |||
| ); | |||
| return distro ? distro.base_path : distro[0].base_path; | |||
There was a problem hiding this comment.
oh :D, sorry for this 🤦
Backport to stable-4.7: 💚 backport PR created✅ Backport PR branch: Backported as #3658 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 27, 2023
* CollectionFilter: change filter names to sentence case * NamespaceDetail: set repository_name filter from /repo/:repo/my-namespaces/:namespace and update on route change, but only when matching or unset * findDistroBasePathByRepo - fall back to first distribution if any, not null[0] * SignCollectionsAPI - support signing by repository name in addition to pulp_href * Namespace detail: sign all collections only signs current repo now make Sign all disabled when a repository is not selected, don't disable it when no collections are found (other filters may be in place), Issue: AAH-2308 * sync fail messages with #3655 (cherry picked from commit 7dd6688)
himdel
added a commit
that referenced
this pull request
Apr 27, 2023
* CollectionFilter: change filter names to sentence case * NamespaceDetail: set repository_name filter from /repo/:repo/my-namespaces/:namespace and update on route change, but only when matching or unset * findDistroBasePathByRepo - fall back to first distribution if any, not null[0] * SignCollectionsAPI - support signing by repository name in addition to pulp_href * Namespace detail: sign all collections only signs current repo now make Sign all disabled when a repository is not selected, don't disable it when no collections are found (other filters may be in place), Issue: AAH-2308 * sync fail messages with #3655 (cherry picked from commit 7dd6688) Co-authored-by: Martin Hradil <mhradil@redhat.com>
github-actions
bot
added
the
backported-4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: AAH-2308
Before: "sign all" would only sign collections in the repository of the first collection of the currently displayed list.
After: "sign all" only works when a repository is selected
Also updates
findDistroBasePathByRepoto fix fallback,allows SignCollectionAPI.sign to find repository by name,
and when using the
myCollectionsByReporoute, use the repo to preset the repository filter