Fix manual approve/reject when repository name is different from distribution base_path #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n base_path when calling the collection version copy/move API, the endpoint accepts source base path and destination base path, those are usually identical to repository name, but not always .. any repo with spaces in the name will have a different base path This ensures we call the endpoint with actual distribution base paths, not repository names. No-Issue
github-actions
bot
added
backport-4.6
himdel
changed the title
himdel
changed the title
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Apr 26, 2023
|
Interesting is that error was here for very long time and nobody noticed, because we were working only with default repos :-) |
Backport to stable-4.7: 💚 backport PR created✅ Backport PR branch: Backported as #3656 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 27, 2023
…n base_path (#3655) when calling the collection version copy/move API, the endpoint accepts source base path and destination base path, those are usually identical to repository name, but not always .. any repo with spaces in the name will have a different base path This ensures we call the endpoint with actual distribution base paths, not repository names. No-Issue (cherry picked from commit d4196c4)
himdel
added a commit
that referenced
this pull request
Apr 27, 2023
* CollectionFilter: change filter names to sentence case * NamespaceDetail: set repository_name filter from /repo/:repo/my-namespaces/:namespace and update on route change, but only when matching or unset * findDistroBasePathByRepo - fall back to first distribution if any, not null[0] * SignCollectionsAPI - support signing by repository name in addition to pulp_href * Namespace detail: sign all collections only signs current repo now make Sign all disabled when a repository is not selected, don't disable it when no collections are found (other filters may be in place), Issue: AAH-2308 * sync fail messages with #3655
patchback bot
pushed a commit
that referenced
this pull request
Apr 27, 2023
* CollectionFilter: change filter names to sentence case * NamespaceDetail: set repository_name filter from /repo/:repo/my-namespaces/:namespace and update on route change, but only when matching or unset * findDistroBasePathByRepo - fall back to first distribution if any, not null[0] * SignCollectionsAPI - support signing by repository name in addition to pulp_href * Namespace detail: sign all collections only signs current repo now make Sign all disabled when a repository is not selected, don't disable it when no collections are found (other filters may be in place), Issue: AAH-2308 * sync fail messages with #3655 (cherry picked from commit 7dd6688)
himdel
added a commit
that referenced
this pull request
Apr 27, 2023
…n base_path (#3655) (#3656) when calling the collection version copy/move API, the endpoint accepts source base path and destination base path, those are usually identical to repository name, but not always .. any repo with spaces in the name will have a different base path This ensures we call the endpoint with actual distribution base paths, not repository names. No-Issue (cherry picked from commit d4196c4) Co-authored-by: Martin Hradil <mhradil@redhat.com>
github-actions
bot
added
the
backported-4.7
himdel
added a commit
that referenced
this pull request
Apr 27, 2023
* CollectionFilter: change filter names to sentence case * NamespaceDetail: set repository_name filter from /repo/:repo/my-namespaces/:namespace and update on route change, but only when matching or unset * findDistroBasePathByRepo - fall back to first distribution if any, not null[0] * SignCollectionsAPI - support signing by repository name in addition to pulp_href * Namespace detail: sign all collections only signs current repo now make Sign all disabled when a repository is not selected, don't disable it when no collections are found (other filters may be in place), Issue: AAH-2308 * sync fail messages with #3655 (cherry picked from commit 7dd6688) Co-authored-by: Martin Hradil <mhradil@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when calling the collection version copy/move API, the endpoint accepts source base path and destination base path, those are usually identical to repository name, but not always .. any repo with spaces in the name will have a different base path
This ensures we call the endpoint with actual distribution base paths, not repository names.
(There may be room for improvement, the first thing the API does with the base path is look up the repository (galaxy_ng/app/api/v3/viewsets/collection.py:239), but not sure that would be backportable.)
Cc @MilanPospisil good catch finding this :)