Update to python 3.8 in Cypress workflow #639

ZitaNemeckova · 2021-07-15T20:42:53Z

Cypress workflow got broken by ansible/galaxy_ng#836

TODO: find a way to prevent it, if possible.

himdel · 2021-07-15T22:00:56Z

👍 Fixes ...

STEP 4: RUN ln /usr/local/lib/python3.6/site-packages/pulp_ansible/app/webserver_snippets/nginx.conf /etc/nginx/pulp/pulp_ansible.conf
ln: failed to access '/usr/local/lib/python3.6/site-packages/pulp_ansible/app/webserver_snippets/nginx.conf': No such file or directory
error building at STEP "RUN ln /usr/local/lib/python3.6/site-packages/pulp_ansible/app/webserver_snippets/nginx.conf /etc/nginx/pulp/pulp_ansible.conf": error while running runtime: exit status 1
time="2021-07-15T19:10:16Z" level=error msg="exit status 1"
Error: Process completed with exit code 1.

during the Build pulp-galaxy-ng step.

himdel · 2021-07-15T22:10:59Z

TODO: find a way to prevent it, if possible.

So,
the Containerfile we're using for cypress .. https://github.com/ansible/ansible-hub-ui/blob/master/.github/workflows/cypress.yml#L50-L60
is a fork of the pulp-galaxy-ng image from pulp-oci-images: https://github.com/pulp/pulp-oci-images/blob/latest/pulp_galaxy_ng/Containerfile .

We could pull from that repo instead of hardcoding our own version, the repo was updated in pulp/pulp-oci-images#103 so it would have been up to date.

The problem is that the image also hardcodes a couple of versions which are wrong for us:

-FROM pulp/pulp-ci-centos:latest
+# default podman config on debian doesn't assume docker.io if no registry specified
+FROM docker.io/pulp/pulp-ci-centos:latest

+# we don't need any of these, definitely not galaxy_ng_version
-ARG PULPCORE_VERSION=">=3.11.2,<3.12"
-ARG PULP_CONTAINER_VERSION=">=2.5.2,<2.6"
-ARG PULP_ANSIBLE_VERSION="==0.7.3"
-ARG GALAXY_NG_VERSION="==4.3.1"

 RUN pip3 install --upgrade \
+  "click<8.0" # might no longer be needed?
   requests \
-  pulpcore${PULPCORE_VERSION} \
-  pulp-container${PULP_CONTAINER_VERSION} \
-  pulp-ansible${PULP_ANSIBLE_VERSION} \
-  galaxy-ng${GALAXY_NG_VERSION}
+  git+https://github.com/ansible/galaxy_ng.git@${{ env.SHORT_BRANCH }} # run galaxy master, stable-4.2 or stable-4.3
 
 RUN ln /usr/local/lib/python3.8/site-packages/pulp_ansible/app/webserver_snippets/nginx.conf /etc/nginx/pulp/pulp_ansible.conf
 RUN ln /usr/local/lib/python3.8/site-packages/pulp_container/app/webserver_snippets/nginx.conf /etc/nginx/pulp/pulp_container.conf
 RUN ln /usr/local/lib/python3.8/site-packages/galaxy_ng/app/webserver_snippets/nginx.conf /etc/nginx/pulp/galaxy_ng.conf

So, we may be able to pull that file, run a script to update it for our needs and then use the updated version.
Not sure if that would be more or less brittle than the current though, might be worth trying :)

Another option might be to RUN ln .../python*/... instead of hardcoding the python version .. assuming only one exists should be safe enough.

patchback · 2021-07-21T12:23:28Z

Beep beep boop!
🤖 Hi, I'm @patchback — your friendly neighborhood robot!

Somebody's just asked me to create a backport of this pull request
into the stable-4.3 branch. So in this comment I report that
I'm on it!

Please, expect to see further updates regarding my progress in updates
to this comment. Stay tuned!

If you think I'm experiencing problems, ping @webknjaz — my creator.

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

himdel · 2021-07-21T12:23:54Z

Adding backport-4.3, to fix python version failures in 4.3 .. https://github.com/ansible/ansible-hub-ui/pull/672/checks?check_run_id=3123350899

webknjaz · 2021-07-21T12:35:26Z

Try re-adding the label. I just received a Sentry error notification. Not sure what happened but it seems like git push failed.

patchback · 2021-07-21T12:36:18Z

Beep beep boop!
🤖 Hi, I'm @patchback — your friendly neighborhood robot!

Somebody's just asked me to create a backport of this pull request
into the stable-4.3 branch. So in this comment I report that
I'm on it!

Please, expect to see further updates regarding my progress in updates
to this comment. Stay tuned!

If you think I'm experiencing problems, ping @webknjaz — my creator.

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

webknjaz · 2021-07-21T12:39:52Z

Weird, it happened again. I wonder if somebody's been messing with the permissions lately...

himdel · 2021-07-21T12:42:42Z

@webknjaz I hope not, it worked an hour ago in #672

webknjaz · 2021-07-21T12:43:39Z

It could be a GH problem or they could change something in the permission model. Try another PR to see if it happens again maybe...

himdel · 2021-07-21T12:49:10Z

@webknjaz Seems to be working just fine in #674, so .. one of those things :)

I can do this one manually, thanks for looking :)

webknjaz · 2021-07-21T12:50:45Z

Please postpone this for 15-30 min, I think I've found the root of the issue. And also I noticed another problem in the code but I want to trigger this flow after the fix once again.

himdel · 2021-07-21T12:51:04Z

No problem :)

webknjaz · 2021-07-21T12:56:24Z

Could you re-apply the label so I could see if I've properly fixed the exception? (there was a silly "tuple doesn't have a replace method" mistake while producing a log message and it wasn't logged properly because of this)

patchback · 2021-07-21T13:02:21Z

Beep beep boop!
🤖 Hi, I'm @patchback — your friendly neighborhood robot!

Somebody's just asked me to create a backport of this pull request
into the stable-4.3 branch. So in this comment I report that
I'm on it!

Please, expect to see further updates regarding my progress in updates
to this comment. Stay tuned!

If you think I'm experiencing problems, ping @webknjaz — my creator.

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

webknjaz · 2021-07-21T13:03:39Z

Urgh.. need another patch. I'll keep you posted.

webknjaz · 2021-07-21T13:13:29Z

Debugging in production be like: Please, retry again...

After this attempt, hopefully the underlying problem will show up in the bot comment. It is indeed a permission error:

! [remote rejected] HEAD -> patchback/backports/stable-4.3/00836c829d0f7851ec451fbf47f388a3bf2603db/pr-639 (refusing to allow a GitHub App to create or update workflow .github/workflows/cypress.yml without workflows permission)
To https://github.com/ansible/ansible-hub-ui.git
error: failed to push some refs to 'https://x-access-token:[Filtered]@github.com/ansible/ansible-hub-ui.git'

webknjaz · 2021-07-21T13:21:22Z

I just want this last test before requesting the proper permission on the App side.

patchback · 2021-07-21T13:22:54Z

Backport to stable-4.3: 💔 cherry-picking failed — conflicts found

❌ Unknown conversion specifier d

Backporting merged PR #639 into master

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible/ansible-hub-ui.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-4.3/00836c829d0f7851ec451fbf47f388a3bf2603db/pr-639 upstream/stable-4.3

Now, cherry-pick PR Update to python 3.8 in Cypress workflow #639 contents into that branch:
```
$ git cherry-pick -x 00836c829d0f7851ec451fbf47f388a3bf2603db
```
If it'll yell at you with something like fatal: Commit 00836c829d0f7851ec451fbf47f388a3bf2603db is a merge but no -m option was given., add -m 1 as follows intead:
```
$ git cherry-pick -m1 -x 00836c829d0f7851ec451fbf47f388a3bf2603db
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR Update to python 3.8 in Cypress workflow #639 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-4.3/00836c829d0f7851ec451fbf47f388a3bf2603db/pr-639

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

webknjaz · 2021-07-21T13:24:12Z

Ouch... Still, there's a problem. Need another patch.

webknjaz · 2021-07-21T13:28:50Z

@himdel could you relabel once again? Funny how much time may pass until somebody hits a rare code branch 🤯. Also, an hour ago had no idea my bot was installed in this repo...

patchback · 2021-07-21T13:34:22Z

Backport to stable-4.3: 💔 cherry-picking failed — could not push

❌ Current GitHub App installation does not grant sufficient privileges for pushing to https://github.com/ansible/ansible-hub-ui.git. Lacking Contents: write or Workflows: write permissions are known to cause this.

the underlying command output was:

$ git --git-dir /tmp/ansible--ansible-hub-ui---stable-4.3---_5lw3yc_---PR-639.git/.git --work-tree /tmp/ansible--ansible-hub-ui---stable-4.3---_5lw3yc_---PR-639.git -c user.email=patchback@sanitizers.bot -c user.name=Patchback push --force-with-lease origin HEAD

[RETURN CODE]: 1

[OUTPUT]:


[STDERR]:

Backporting merged PR #639 into master

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible/ansible-hub-ui.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-4.3/00836c829d0f7851ec451fbf47f388a3bf2603db/pr-639 upstream/stable-4.3

Now, cherry-pick PR Update to python 3.8 in Cypress workflow #639 contents into that branch:
```
$ git cherry-pick -x 00836c829d0f7851ec451fbf47f388a3bf2603db
```
If it'll yell at you with something like fatal: Commit 00836c829d0f7851ec451fbf47f388a3bf2603db is a merge but no -m option was given., add -m 1 as follows intead:
```
$ git cherry-pick -m1 -x 00836c829d0f7851ec451fbf47f388a3bf2603db
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR Update to python 3.8 in Cypress workflow #639 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-4.3/00836c829d0f7851ec451fbf47f388a3bf2603db/pr-639

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

himdel · 2021-07-21T13:35:32Z

Heheh, it's everywhere :)

And no worries, I too know the pains of debugging these things :)

webknjaz · 2021-07-21T13:38:16Z

I guess I'll stop now. Even though there are more imporovements to do (like making stderr/stdout actually show up), I'll postpone this — the displayed note is useful enough already and I need to switch over to other tasks.
Will ask @gundalow to update the permissions and this should fix it.

webknjaz · 2021-07-21T13:42:27Z

@himdel the permissions are fixed now. If you retry, it should create a backport.

himdel · 2021-07-21T14:15:14Z

Thanks for the update! :)

In the meantime I've found out that we need to stay on python3.6 on that branch for now.
Removing the label.

webknjaz · 2021-07-21T15:53:28Z

Maybe you could trigger it just for the sake of a test (and then close the PR).

patchback · 2021-07-21T21:45:17Z

Backport to stable-4.3: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 00836c8 on top of patchback/backports/stable-4.3/00836c829d0f7851ec451fbf47f388a3bf2603db/pr-639

Backporting merged PR #639 into master

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible/ansible-hub-ui.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-4.3/00836c829d0f7851ec451fbf47f388a3bf2603db/pr-639 upstream/stable-4.3

Now, cherry-pick PR Update to python 3.8 in Cypress workflow #639 contents into that branch:
```
$ git cherry-pick -x 00836c829d0f7851ec451fbf47f388a3bf2603db
```
If it'll yell at you with something like fatal: Commit 00836c829d0f7851ec451fbf47f388a3bf2603db is a merge but no -m option was given., add -m 1 as follows intead:
```
$ git cherry-pick -m1 -x 00836c829d0f7851ec451fbf47f388a3bf2603db
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR Update to python 3.8 in Cypress workflow #639 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-4.3/00836c829d0f7851ec451fbf47f388a3bf2603db/pr-639

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

himdel · 2021-07-21T21:45:36Z

Ah, sure :) here it goes ^ :)

(I guess that's no longer so helpful is it? :( )

Let me know if you want us to create/find a PR that touches a workflow and can be backported cleanly.

webknjaz · 2021-07-21T21:49:23Z

Let me know if you want us to create/find a PR that touches a workflow and can be backported cleanly.

That would be nice, if it's not too much of a hustle :)

himdel · 2021-07-21T22:04:17Z

It may take a bit, but I think we'll be able to try with #642 once merged, I'll ping you ~~tomorrow~~ today :)

Update to python 3.8

0cbadef

ZitaNemeckova requested a review from himdel July 15, 2021 20:50

himdel merged commit 00836c8 into ansible:master Jul 15, 2021

ZitaNemeckova mentioned this pull request Jul 16, 2021

Do not hardcode python version. Assume there's gonna be only one FIXM… #642

Merged

himdel mentioned this pull request Jul 19, 2021

Toolbar aligning with top pagination on group list page and container registry page #638

Merged

jerabekjiri pushed a commit to jerabekjiri/ansible-hub-ui that referenced this pull request Jul 20, 2021

Update to python 3.8 (ansible#639)

318af62

himdel added the backport-4.3 label Jul 21, 2021

himdel added backport-4.3 and removed backport-4.3 labels Jul 21, 2021

ZitaNemeckova deleted the fix_cypress branch July 21, 2021 13:17

himdel removed the backport-4.3 label Jul 21, 2021

himdel added the backport-4.3 label Jul 21, 2021

himdel added backport-4.3 and removed backport-4.3 labels Jul 21, 2021

himdel removed the backport-4.3 label Jul 21, 2021

himdel mentioned this pull request Jul 21, 2021

[stable-4.3] Use a python36 version of pulp-ci-centos #675

Merged

himdel added the backport-4.3 label Jul 21, 2021

himdel removed the backport-4.3 label Jul 21, 2021

himdel mentioned this pull request Jul 23, 2021

cypress: remove click<8 dependency, we're fine with 8+ now #671

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to python 3.8 in Cypress workflow #639

Update to python 3.8 in Cypress workflow #639

ZitaNemeckova commented Jul 15, 2021 •

edited

Loading

himdel commented Jul 15, 2021

himdel commented Jul 15, 2021 •

edited

Loading

patchback bot commented Jul 21, 2021

himdel commented Jul 21, 2021

webknjaz commented Jul 21, 2021

patchback bot commented Jul 21, 2021

webknjaz commented Jul 21, 2021

himdel commented Jul 21, 2021

webknjaz commented Jul 21, 2021

himdel commented Jul 21, 2021

webknjaz commented Jul 21, 2021

himdel commented Jul 21, 2021

webknjaz commented Jul 21, 2021

patchback bot commented Jul 21, 2021

webknjaz commented Jul 21, 2021

webknjaz commented Jul 21, 2021

webknjaz commented Jul 21, 2021

patchback bot commented Jul 21, 2021 •

edited

Loading

webknjaz commented Jul 21, 2021

webknjaz commented Jul 21, 2021 •

edited

Loading

patchback bot commented Jul 21, 2021 •

edited

Loading

himdel commented Jul 21, 2021

webknjaz commented Jul 21, 2021

webknjaz commented Jul 21, 2021

himdel commented Jul 21, 2021

webknjaz commented Jul 21, 2021

patchback bot commented Jul 21, 2021 •

edited

Loading

himdel commented Jul 21, 2021 •

edited

Loading

webknjaz commented Jul 21, 2021

himdel commented Jul 21, 2021 •

edited

Loading

Update to python 3.8 in Cypress workflow #639

Update to python 3.8 in Cypress workflow #639

Conversation

ZitaNemeckova commented Jul 15, 2021 • edited Loading

himdel commented Jul 15, 2021

himdel commented Jul 15, 2021 • edited Loading

patchback bot commented Jul 21, 2021

himdel commented Jul 21, 2021

webknjaz commented Jul 21, 2021

patchback bot commented Jul 21, 2021

webknjaz commented Jul 21, 2021

himdel commented Jul 21, 2021

webknjaz commented Jul 21, 2021

himdel commented Jul 21, 2021

webknjaz commented Jul 21, 2021

himdel commented Jul 21, 2021

webknjaz commented Jul 21, 2021

patchback bot commented Jul 21, 2021

webknjaz commented Jul 21, 2021

webknjaz commented Jul 21, 2021

webknjaz commented Jul 21, 2021

patchback bot commented Jul 21, 2021 • edited Loading

Backport to stable-4.3: 💔 cherry-picking failed — conflicts found

Backporting merged PR #639 into master

webknjaz commented Jul 21, 2021

webknjaz commented Jul 21, 2021 • edited Loading

patchback bot commented Jul 21, 2021 • edited Loading

Backport to stable-4.3: 💔 cherry-picking failed — could not push

Backporting merged PR #639 into master

himdel commented Jul 21, 2021

webknjaz commented Jul 21, 2021

webknjaz commented Jul 21, 2021

himdel commented Jul 21, 2021

webknjaz commented Jul 21, 2021

patchback bot commented Jul 21, 2021 • edited Loading

Backport to stable-4.3: 💔 cherry-picking failed — conflicts found

Backporting merged PR #639 into master

himdel commented Jul 21, 2021 • edited Loading

webknjaz commented Jul 21, 2021

himdel commented Jul 21, 2021 • edited Loading

ZitaNemeckova commented Jul 15, 2021 •

edited

Loading

himdel commented Jul 15, 2021 •

edited

Loading

patchback bot commented Jul 21, 2021 •

edited

Loading

webknjaz commented Jul 21, 2021 •

edited

Loading

patchback bot commented Jul 21, 2021 •

edited

Loading

patchback bot commented Jul 21, 2021 •

edited

Loading

himdel commented Jul 21, 2021 •

edited

Loading

himdel commented Jul 21, 2021 •

edited

Loading