Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cypress: remove click<8 dependency, we're fine with 8+ now #671

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Jul 20, 2021

to match ansible/galaxy_ng#844

(This will be relevant for 4.3 if we ever switch to python3.8, so just mentiononing #639, #642 for linkage.)

@himdel
Copy link
Collaborator Author

himdel commented Jul 23, 2021

🎉 it built and passed in https://github.com/ansible/ansible-hub-ui/pull/671/checks?check_run_id=3143424646

(removing cache key change, should be ready)

@himdel himdel changed the title [WIP] cypress: remove click<8 dependency, we're fine with 8+ now cypress: remove click<8 dependency, we're fine with 8+ now Jul 23, 2021
@himdel
Copy link
Collaborator Author

himdel commented Jul 26, 2021

Cc @ZitaNemeckova

@himdel himdel requested a review from ZitaNemeckova August 2, 2021 12:14
@himdel himdel merged commit 3ee1cdb into ansible:master Aug 2, 2021
@himdel himdel deleted the cypress-click branch August 2, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants