3.4.0 Regression: dependency check does not completely honor the enable: false

[fcharlier]

Issue Type

• Bug report

Molecule and Ansible details

>  .tox/py36/bin/molecule --version
molecule 3.4.0 using python 3.6
    ansible:2.9.25
    delegated:3.4.0 from molecule
    podman:1.0.1 from molecule_podman requiring collections: containers.podman>=1.7.0 ansible.posix>=1.3.0

Molecule installation method (one of):

• pip

Ansible installation method (one of):

• OS package

Desired Behavior

With molecule/default/molecule.yml containing

---
dependency:
  name: galaxy
  enabled: false

The dependency check should be print (output from molecule 3.3.4):

INFO     Running default > dependency
WARNING  Skipping, dependency is disabled.
WARNING  Skipping, dependency is disabled.
INFO     Running default > syntax

Actual Behaviour

Instead it tries to install the podman driver dependency:

INFO     Running default > dependency
INFO     Running ansible-galaxy collection install --force -v containers.podman:>=1.7.0
CRITICAL Collection 'containers.podman' not found in '['/home/[user]/.cache/ansible-lint/dbf977/collections', '/home/[user]/.ansible/collections', '/usr/share/ansible/collections']'
WARNING  An error occurred during the test sequence action: 'dependency'. Cleaning up.

I suppose it's due to #3192 which calls super.execute() before verifying if the dependency check is enabled or not in src/molecule/dependency/shell.py

[ssbarnea]

@fcharlier I think you are right. Can you test locally if moving the super call to the else branch of the if is fixing the issue? If it works you can also make the PR for it.

The problem is important enough to make a bugfix release for it and I can help with that.

[fcharlier]

After moving the call to super.execute() after the if not self.enabled: check (see diffs at the end of the message), the dependency checker is skipped as expected.

INFO     Running default > dependency
WARNING  Skipping, dependency is disabled.
WARNING  Skipping, dependency is disabled.
INFO     Running default > syntax

The diffs

*** .tox/py36/lib/python3.6/site-packages/molecule/dependency/shell.py.old	2021-09-08 17:15:44.639945919 +0200
--- .tox/py36/lib/python3.6/site-packages/molecule/dependency/shell.py	2021-09-08 17:17:58.855439536 +0200
***************
*** 87,102 ****
      def bake(self) -> None:
          """Bake a ``shell`` command so it's ready to execute."""
          self._sh_command = BakedCommand(cmd=self.command, env=self.env)

      def execute(self):
-         super().execute()
          if not self.enabled:
              msg = "Skipping, dependency is disabled."
              LOG.warning(msg)
              return

          if self._sh_command is None:
              self.bake()

          self.execute_with_retries()

--- 87,103 ----
      def bake(self) -> None:
          """Bake a ``shell`` command so it's ready to execute."""
          self._sh_command = BakedCommand(cmd=self.command, env=self.env)

      def execute(self):
          if not self.enabled:
              msg = "Skipping, dependency is disabled."
              LOG.warning(msg)
              return

+         super().execute()
+
          if self._sh_command is None:
              self.bake()

          self.execute_with_retries()

*** .tox/py36/lib/python3.6/site-packages/molecule/dependency/ansible_galaxy/base.py.old	2021-09-08 17:20:17.016800665 +0200
--- .tox/py36/lib/python3.6/site-packages/molecule/dependency/ansible_galaxy/base.py	2021-09-08 17:20:20.980667576 +0200
***************
*** 111,126 ****
              cmd=[self.command, *self.COMMANDS, *util.dict2args(options), *verbose_flag],
              env=self.env,
          )

      def execute(self):
-         super().execute()
          if not self.enabled:
              msg = "Skipping, dependency is disabled."
              LOG.warning(msg)
              return

          if not self._has_requirements_file():
              msg = "Skipping, missing the requirements file."
              LOG.warning(msg)
              return

--- 111,126 ----
              cmd=[self.command, *self.COMMANDS, *util.dict2args(options), *verbose_flag],
              env=self.env,
          )

      def execute(self):
          if not self.enabled:
              msg = "Skipping, dependency is disabled."
              LOG.warning(msg)
              return

+         super().execute()
          if not self._has_requirements_file():
              msg = "Skipping, missing the requirements file."
              LOG.warning(msg)
              return

[fcharlier]

@ssbarnea the #3235 commit fixes the issue only for the "shell" dependency checker, not for the "galaxy" checker.

The ansible_galaxy/base.py file requires the same change.