Allow molecule drivers to require collections #3192
Merged
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables drivers to expose the list of required collections they need for running. Molecule will display required collections for each driver as part of `molecule --version` listing. During 'dependency' run molecule will check for presence of required collections and install/upgrade them if needed.
ssbarnea
added a commit
to ansible-community/molecule-docker
that referenced
this pull request
Jul 19, 2021
Depends-On: ansible/molecule#3192
ssbarnea
added a commit
to ansible-community/molecule-docker
that referenced
this pull request
Jul 19, 2021
Depends-On: ansible/molecule#3192
ssbarnea
added a commit
to ansible-community/molecule-podman
that referenced
this pull request
Jul 19, 2021
Use new molecule API to expose required collection and removes dependency on ansiblelint.prerun module. Depends-On: ansible/molecule#3192
tadeboro
approved these changes
Jul 19, 2021
ssbarnea
added a commit
to ansible-community/molecule-docker
that referenced
this pull request
Jul 19, 2021
Depends-On: ansible/molecule#3192
ssbarnea
added a commit
to ansible-community/molecule-podman
that referenced
this pull request
Jul 19, 2021
Use new molecule API to expose required collection and removes dependency on ansiblelint.prerun module. Depends-On: ansible/molecule#3192
ssbarnea
added a commit
to ansible-community/molecule-podman
that referenced
this pull request
Jul 19, 2021
Use new molecule API to expose required collection and removes dependency on ansiblelint.prerun module. Depends-On: ansible/molecule#3192
rafasgj
pushed a commit
to rafasgj/ansible-freeipa
that referenced
this pull request
Aug 25, 2021
Remove dependency on ansible.posix collection. Explicitly install community.docker collection due to molecule[docker] bug. See ansible/molecule#3192.
rafasgj
pushed a commit
to rafasgj/ansible-freeipa
that referenced
this pull request
Oct 5, 2021
Remove dependency on ansible.posix collection. Explicitly install community.docker collection due to molecule[docker] bug. See ansible/molecule#3192.
ziegenberg
added a commit
to ziegenberg/molecule-openstack
that referenced
this pull request
Mar 31, 2022
This lifts the minimum required molecule version to 3.4.0 Depends-On: ansible/molecule#3192 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ssbarnea
pushed a commit
to ansible-community/molecule-openstack
that referenced
this pull request
Mar 31, 2022
This lifts the minimum required molecule version to 3.4.0 Depends-On: ansible/molecule#3192 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables drivers to expose the list of required collections they need for running.
Molecule will display required collections for each driver as part of
molecule --versionlisting.During 'dependency' run molecule will check for presence of required collections and install/upgrade them if needed.
The need for this feature was discovered when newer versions of plugins like docker and podman started to require versions of their collections that do not ship with ansible 2.9. By checking presence of required collections at runtime, we can avoid confusing errors for the users.