Skip to content
This repository was archived by the owner on Feb 25, 2019. It is now read-only.

Eliminate repetitive code in signin, signup, and signout #143

Closed
adalinesimonian opened this issue Aug 9, 2015 · 1 comment
Closed

Eliminate repetitive code in signin, signup, and signout #143

adalinesimonian opened this issue Aug 9, 2015 · 1 comment

Comments

@adalinesimonian
Copy link
Member

There exists a number of passages of code in signin, signup, and signout which are repeated throughout with minor differences.

@christiansmith
Copy link
Member

Just to give everyone else context, we took a crack at this and Passport complicates the matter because of the way it monkey patches http.req. The code we ended up with on the first pass seemed dirtier than having some repetition so we backed out the changes. Ugh.

adalinesimonian added a commit that referenced this issue Aug 29, 2015
Logic in the passport library was conflicting in scope with Anvil
Connect's own provider handling.

Now, strategies are interfaced with directly, and there is no need to
bring in the passport library itself.

This maintains compatibility with existing passport strategies.

Fixes #143
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants