This repository was archived by the owner on Feb 25, 2019. It is now read-only.
Remove passport dependency #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logic in the passport library was conflicting in scope with Anvil Connect's own provider handling. Now, strategies are interfaced with directly, and there is no need to bring in the passport library itself. This maintains compatibility with existing passport strategies. Fixes #143
|
With additional fixes, this PR now has grown in scope and fixes #138 |
christiansmith
added a commit
that referenced
this pull request
Aug 30, 2015
Remove passport dependency
|
Awesome work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic in the passport library was conflicting in scope with Anvil Connect's own provider handling.
Now, strategies are interfaced with directly, and there is no need to bring in the passport library itself.
This maintains compatibility with existing passport strategies.
Fixes #143