Fix: Override FAB styling #11752
Merged
Fix: Override FAB styling #11752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
approved these changes
Oct 22, 2020
ryanahamilton
force-pushed
the
fix_fab_menu_styling
branch
from
53fca75 to
1896a0b
Compare
|
Should we introduce a similar change to FAB? |
|
@mik-laj yes, I was looking into the code there. It would likely just be a change that would negate the need for this one. This can be a band-aid until that one can be adopted in Airflow. |
6 tasks
mik-laj
approved these changes
Oct 22, 2020
|
PR'ed the FAB fix as well: dpgaspar/Flask-AppBuilder#1491 |
kaxil
approved these changes
Oct 22, 2020
6 tasks
ryanahamilton
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 27, 2020
This reverts commit 2df9d1c.
ryw
pushed a commit
that referenced
this pull request
Oct 27, 2020
michalmisiewicz
pushed a commit
to michalmisiewicz/airflow
that referenced
this pull request
Oct 30, 2020
michalmisiewicz
pushed a commit
to michalmisiewicz/airflow
that referenced
this pull request
Oct 30, 2020
This reverts commit 2df9d1c.
szn
pushed a commit
to szn/airflow
that referenced
this pull request
Nov 1, 2020
szn
pushed a commit
to szn/airflow
that referenced
this pull request
Nov 1, 2020
This reverts commit 2df9d1c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FAB is going against Boostrap's Dropdown guidelines by adding a
btnclass on the anchors within the drop-down menus. This yields some undesirable styling. This PR offers a simple CSS override to improve the aesthetics.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.