Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary CSS class/styling from dropdowns #1503

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

ryanahamilton
Copy link
Contributor

Redo of #1491

This time leaving the filter class in place that is utilized by scripting, but still removing the undesired styling associated with it.

Description

Adhering to Bootstrap's Dropdown guidelines, the anchors within dropdown elements should not have any styled CSS classes on them. This PR removes the btn classe added in FAB as they were yielding undesirable side effects (see Airflow patch fix).

The .btn.filter styling that I removed in this PR appears to have been added by #493, but was likely only needed to begin with because of the presence of the btn class (which center aligned the text).

Before After
Image 2020-10-22 at 4 31 32 PM Image 2020-10-22 at 4 30 52 PM

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #1503 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1503   +/-   ##
=======================================
  Coverage   72.74%   72.74%           
=======================================
  Files          46       46           
  Lines        6354     6354           
=======================================
  Hits         4622     4622           
  Misses       1732     1732           
Flag Coverage Δ
#python 72.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03fb608...d6a4fef. Read the comment docs.

Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants