Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Use dict.get in Meson Configuration #45775

Closed
WillAyd opened this issue Mar 13, 2025 · 1 comment
Closed

[C++] Use dict.get in Meson Configuration #45775

WillAyd opened this issue Mar 13, 2025 · 1 comment
Assignees
@WillAyd
Labels
Component: C++ Type: enhancement
Milestone
20.0.0

Comments

@WillAyd
Copy link
Contributor

WillAyd commented Mar 13, 2025

Describe the enhancement requested

Our current Meson configuration requires users to specify empty list entries within dictionaries when they are not applicable. To make the configuration smaller, we can use dict.get() with a default empty list value instead of trying to access using bracket notation

Component(s)

C++
WillAyd added a commit to WillAyd/arrow that referenced this issue Mar 13, 2025
@WillAyd
apacheGH-45775: [C++] Use dict.get() in Meson configuration
2d8ef28
@github-actions github-actions bot mentioned this issue Mar 13, 2025
Merged
kou pushed a commit that referenced this issue Mar 14, 2025
@WillAyd
GH-45775: [C++] Use dict.get() in Meson configuration (#45776)
5641cd5 
### Rationale for this change

This change cuts down on the verbosity of the Meson configuration

### What changes are included in this PR?

dict.get() with an empty list default value is used in lieu of requiring every dictionary to create keys with empty list values, where applicable

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* GitHub Issue: #45775

Authored-by: Will Ayd <william.ayd@icloud.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou
Copy link
Member

kou commented Mar 14, 2025

Issue resolved by pull request 45776
#45776

@kou kou added this to the 20.0.0 milestone Mar 14, 2025
@kou kou closed this as completed Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WillAyd WillAyd

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
20.0.0
Development

No branches or pull requests
2 participants
@kou @WillAyd