Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45775: [C++] Use dict.get() in Meson configuration #45776

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

WillAyd
Copy link
Contributor

@WillAyd WillAyd commented Mar 13, 2025

Rationale for this change

This change cuts down on the verbosity of the Meson configuration

What changes are included in this PR?

dict.get() with an empty list default value is used in lieu of requiring every dictionary to create keys with empty list values, where applicable

Are these changes tested?

Yes

Are there any user-facing changes?

No

Copy link

⚠️ GitHub issue #45775 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 5641cd5 into apache:main Mar 14, 2025
37 checks passed
@kou kou removed the awaiting review Awaiting review label Mar 14, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Mar 14, 2025
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5641cd5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants