Revised solution for PyGobject handling based on pinning. #2190
+27
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion on beeware/toga#3143, this is an updated approach to PyGObject handling for Toga apps on Linux.
It imposes an upper version pin on PyGObject, effectively pinning it to 3.50.0 for all Linux releases, and using girepository-1.0 everywhere. This ensures that it will work on all supported Linux releases by default, without any modifications. However, documentation inline provides a guide for releasing the pin if the user doesn't care about older Debian and Ubuntu support.
PR Checklist: