Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trackers Blocked on new tab always shows zero #1735

Closed
btlechowski opened this issue Oct 19, 2018 · 5 comments · Fixed by brave/brave-core#703
Closed

Trackers Blocked on new tab always shows zero #1735

btlechowski opened this issue Oct 19, 2018 · 5 comments · Fixed by brave/brave-core#703

Comments

@btlechowski
Copy link

btlechowski commented Oct 19, 2018

Trackers and ads get counted together on newtab page.

Steps to Reproduce

  1. Clean install
  2. Open https://jsfiddle.net/bkf50r8v/13/
  3. Open a new tab and check Trackers Blocked

Actual result:

Trackers Blocked shows 0
image

Expected result:

Trackers Blocked shows 1

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows 7 x64

Reproduced by @GeetaSarvadnya on Windows 10

cc @srirambv @LaurenWags @kjozwiak to check on other platform

@btlechowski btlechowski added feature/shields The overall Shields feature in Brave. feature/new-tab QA/Yes labels Oct 19, 2018
@btlechowski btlechowski added this to the 0.56.x - Beta milestone Oct 19, 2018
@btlechowski btlechowski changed the title Trackers Blocked on new page always show zero Trackers Blocked on new tab always show zero Oct 19, 2018
@btlechowski btlechowski changed the title Trackers Blocked on new tab always show zero Trackers Blocked on new tab always shows zero Oct 19, 2018
@Brave-Matt
Copy link

@eljuno
Copy link

eljuno commented Oct 19, 2018

@cndouglas
Copy link
Contributor

+1 from me. Brave 0.57.1 on macOS 10.14.

@srirambv
Copy link
Contributor

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 23, 2018

Verification Passed on:

Brave 0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows

1735

Verification Passed on:

Brave 0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Linux
  • Verified ads and trackers blocked as counted individually on sites

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment