Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count TP blocks separately on newtab page #703

Merged
merged 1 commit into from
Oct 21, 2018
Merged

Count TP blocks separately on newtab page #703

merged 1 commit into from
Oct 21, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Oct 20, 2018

Fix brave/brave-browser#1735

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy bbondy self-assigned this Oct 20, 2018
@bbondy bbondy requested a review from emerick October 20, 2018 19:27
emerick
emerick approved these changes Oct 20, 2018
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit 2fabf17 into master Oct 21, 2018
bbondy added a commit that referenced this pull request Oct 21, 2018
@bbondy
Merge pull request #703 from brave/fix-tp-count
0209b45 
Count TP blocks separately on newtab page
bbondy added a commit that referenced this pull request Oct 21, 2018
@bbondy
Merge pull request #703 from brave/fix-tp-count
14484c3 
Count TP blocks separately on newtab page
@bbondy
Copy link
Member Author

bbondy commented Oct 21, 2018 •
edited
Loading

master: 2fabf17
0.57.x: 0209b45
0.56.x: 14484c3
0.55.x: ad63b66

bbondy added a commit that referenced this pull request Oct 21, 2018
@bbondy
Merge pull request #703 from brave/fix-tp-count
ad63b66 
Count TP blocks separately on newtab page
@bsclifton bsclifton deleted the fix-tp-count branch November 5, 2018 18:49
@bbondy bbondy removed the 0.55.x label Jan 14, 2019
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
@snyk-bot snyk-bot mentioned this pull request Jul 28, 2021
Open
This was referenced Apr 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Trackers Blocked on new tab always shows zero
2 participants
@bbondy @emerick