Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash inside BraveRewardsHelper #42319

Closed
SergeyZhukovsky opened this issue Nov 15, 2024 · 0 comments · Fixed by brave/brave-core#26724
Closed

Crash inside BraveRewardsHelper #42319

SergeyZhukovsky opened this issue Nov 15, 2024 · 0 comments · Fixed by brave/brave-core#26724
Assignees
@AlexeyBarabash
Labels
crash feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Milestone
1.75.x - Release

Comments

@SergeyZhukovsky
Copy link
Member

It's seen on stable 1.73.89. We might need to uplift, depending on how many crashes we see.

Exception java.lang.IllegalStateException: Attempting to access TabModelSelector before initialization
  at org.chromium.chrome.browser.app.ChromeActivity.getTabModelSelector (ChromeActivity.java:1936)
  at org.chromium.chrome.browser.BraveRewardsHelper.currentActiveChromeTabbedActivityTab (BraveRewardsHelper.java:433)
  at org.chromium.chrome.browser.BraveRewardsNativeWorker$2.run (BraveRewardsNativeWorker.java:157)
  at android.os.Handler.handleCallback (Handler.java:938)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loopOnce (Looper.java:201)
  at android.os.Looper.loop (Looper.java:288)
  at android.app.ActivityThread.main (ActivityThread.java:7932)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:553)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1003)
@SergeyZhukovsky SergeyZhukovsky added crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include labels Nov 15, 2024
@SergeyZhukovsky SergeyZhukovsky self-assigned this Nov 15, 2024
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Nov 25, 2024
@AlexeyBarabash
Guard ChromeActivity.getTabModelSelector() with areTabModelsInitializ…

Verified

This commit was signed with the committer’s verified signature.
AlexeyBarabash
SSH Key Fingerprint: bBcDCnavgf+2OsmOIKIdXSUeA4r/Rcj1LAG353gh7dw
Verified
Learn about vigilant mode
Loading
Loading status checks…
d513bc5 
…ed()

Fixes crash reported from GP dev console.

Fixes brave/brave-browser#42319
@AlexeyBarabash AlexeyBarabash mentioned this issue Nov 25, 2024
Merged
24 tasks
@brave-builds brave-builds added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 26, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 26, 2024
@hffvld hffvld mentioned this issue Feb 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
crash feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Projects
None yet
Milestone
1.75.x - Release
Development

Successfully merging a pull request may close this issue.

Guard ChromeActivity.getTabModelSelector with areTabModelsInitialized brave/brave-core
3 participants
@SergeyZhukovsky @AlexeyBarabash @brave-builds