Guard ChromeActivity.getTabModelSelector with areTabModelsInitialized #26724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed() Fixes crash reported from GP dev console. Fixes brave/brave-browser#42319
simoarpe
approved these changes
Nov 25, 2024
Comment on lines
1224
to
1226
| if (!chromeActivity.areTabModelsInitialized()) { | ||
| return ProfileManager.getLastUsedRegularProfile(); | ||
| } |
There was a problem hiding this comment.
Because both return ProfileManager.getLastUsedRegularProfile(); I would unify this if statement with the one above by simply changing the condition into if (chromeActivity == null || !chromeActivity.areTabModelsInitialized())
There was a problem hiding this comment.
thanks, fixed at a2a11d8
| ChromeTabbedActivity activity = BraveRewardsHelper.getChromeTabbedActivity(); | ||
| if (activity == null | ||
| || !activity.areTabModelsInitialized() | ||
| || activity.getTabModelSelector() == null) { |
There was a problem hiding this comment.
could you please also change getTabModelSelector(it's deprecated) to getTabModelSelectorSupplier as
There was a problem hiding this comment.
thanks, changed at 3ba5886
…ctor, codereview notice.
|
Released in v1.75.53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes crash reported from GP dev console, also fixes other similar palces.
Fixes brave/brave-browser#42319
Resolves brave/brave-browser#42319
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
There is no one, crash was reported from GP dev console.