Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser test failure on Windows (debug) #5736

Closed
bsclifton opened this issue Aug 20, 2019 · 0 comments · Fixed by brave/brave-core#3222
Closed

browser test failure on Windows (debug) #5736

bsclifton opened this issue Aug 20, 2019 · 0 comments · Fixed by brave/brave-core#3222

Comments

@bsclifton
Copy link
Member

Description

Browser test failure unintentionally introduced with brave/brave-core#3154

Steps to Reproduce

  1. Be on Windows
  2. Check out master
  3. Do debug build
  4. Run browser tests with npm run test brave_browser_tests

Actual result:

BraveProfilePrefsBrowserTest.AdvancedShieldsExistingUserValue fails:

[8784:8388:0819/155955.361:FATAL:thread_restrictions.cc(76)] Check failed: !g_blocking_disallowed.Get().Get(). Function marked as blocking was called from a scope that disallows blocking! If this task is running inside the ThreadPool, it needs to have MayBlock() in its TaskTraits. Otherwise, consider making this blocking work asynchronous or, as a last resort, you may use ScopedAllowBlocking (see its documentation for best practices).
g_blocking_disallowed currently set to true by

Expected result:

No failures

Reproduces how often:

100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant