Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code that was trying to create sentinel file (which already #3222

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

bsclifton
Copy link
Member

existed)

Fixes brave/brave-browser#5736

Problem was introduced in #3154

This is blocking uplifts:

Submitter Checklist:

Test Plan:

npm run test brave_browser_tests

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton bsclifton added this to the 0.71.x - Nightly milestone Aug 20, 2019
@bsclifton bsclifton requested a review from mkarolin August 20, 2019 16:17
@bsclifton bsclifton self-assigned this Aug 20, 2019
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 2f09abf into master Aug 20, 2019
@bsclifton bsclifton deleted the bsc-fix-shields-browser-test branch August 20, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

browser test failure on Windows (debug)
2 participants