Default shield advanced view to TRUE for existing users. (uplift to 0.69.x)

[bsclifton]

Fixes brave/brave-browser#5582

Uplift of #3154

Approved, please ensure that before merging:

• You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
• You have tested your change on Nightly.
• The PR milestones match the branch they are landing to.

After you merge:

• The associated issue milestone is set to the smallest version that the changes is landed on.

[bsclifton]

NOTE: not ready to be merged; there is a failing browser test on WINDOWS only... investigating...

[bsclifton]

Ready for consideration 😄 Above issue fixed

[kjozwiak]

@bsclifton mind taking a look at some of these failures?

• https://staging.ci.brave.com/job/brave-browser-build-pr/job/pr3154-0.69.x/2/execution/node/286/log/

13:30:54  [33367/40121] CXX obj/brave/browser/ui/ui/brave_web_ui_controller_factory.o
13:30:54  [33368/40121] CXX obj/brave/browser/browser_process/brave_profile_prefs.o
13:30:54  FAILED: obj/brave/browser/browser_process/brave_profile_prefs.o 

13:31:03  [33405/40121] CXX obj/brave/browser/browser_process/brave_content_browser_client.o
13:31:03  ninja: build stopped: subcommand failed.

• https://staging.ci.brave.com/job/brave-browser-build-pr/job/pr3154-0.69.x/2/execution/node/185/log/

12:55:42  [21825/37908] CXX obj/chrome/browser/ui/ui/sad_tab.o
12:55:42  [21826/37908] CXX obj/brave/browser/browser_process/brave_profile_prefs.o
12:55:42  FAILED: obj/brave/browser/browser_process/brave_profile_prefs.o

12:55:52  [21863/37908] CXX obj/brave/browser/browser_process/brave_content_browser_client.o
12:55:52  ninja: build stopped: subcommand failed.

• https://staging.ci.brave.com/job/brave-browser-build-pr/job/pr3154-0.69.x/2/execution/node/504/log/

13:54:31  [27495/37908] CXX obj/brave/browser/browser_process/brave_profile_prefs.o
13:54:31  FAILED: obj/brave/browser/browser_process/brave_profile_prefs.o 

13:54:32  [27508/37908] CXX obj/brave/browser/ui/ui/brave_new_tab_button.o
13:54:32  ninja: build stopped: subcommand failed.

• https://staging.ci.brave.com/job/brave-browser-build-pr/job/pr3154-0.69.x/2/execution/node/375/log/

[bsclifton]

@kjozwiak I believe we need to accept #3187 first (and then I can rebase this). Will mark as blocked

[bsclifton]

Rebased - ready for approval / merge (after CI runs)

[kjozwiak]

@bsclifton looks like the following checks have failed under CI/Jenkins:

npm run test -- brave_browser_tests Release --output brave_browser_tests.xml under linux via the following:

• https://staging.ci.brave.com/job/brave-browser-build-pr/job/pr3154-0.69.x/1/execution/node/595/log/

npm run test -- brave_browser_tests Release --output brave_browser_tests.xml via under MacOS via the following:

• https://staging.ci.brave.com/job/brave-browser-build-pr/job/pr3154-0.69.x/1/execution/node/493/log/

[bsclifton]

Problem found + fixed - when uplifting, I missed the removal of the check in browser/brave_profile_prefs_browsertest.cc. Added this back in (so it matches other branches) and CI is re-running now

[kjozwiak]

Uplift into 0.69.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues or failures. Please make sure that the correct labels are added and the associated issue is moved into the correct milestone.