Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set shields interface views as a global default in settings (uplift to 0.69.x) #3187

Merged
merged 1 commit into from
Aug 28, 2019
Merged

set shields interface views as a global default in settings (uplift to 0.69.x) #3187

merged 1 commit into from
Aug 28, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Aug 15, 2019 •
edited
Loading

Fixes brave/brave-browser#4784

Uplift of #2973

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton bsclifton added this to the 0.69.x - Beta milestone Aug 15, 2019
@bsclifton bsclifton requested a review from a team August 15, 2019 07:24
@bsclifton bsclifton self-assigned this Aug 15, 2019
@bsclifton bsclifton changed the title Merge pull request #2973 from brave/ca-4784 set shields interface views as a global default in settings (uplift to 0.69.x) Aug 15, 2019
@bsclifton bsclifton mentioned this pull request Aug 15, 2019
Merged
6 tasks
cezaraugusto
cezaraugusto previously approved these changes Aug 15, 2019
View reviewed changes
@cezaraugusto
Copy link
Contributor

@bsclifton this PR is set as a draft. on purpose?

@bsclifton
Copy link
Member Author

bsclifton commented Aug 15, 2019 •
edited
Loading

@cezaraugusto yup- i wanted to make sure it works (compiling now) before letting CI run (only because there was a merge conflict). But since that takes a while, let me make it ready for review

@bsclifton bsclifton marked this pull request as ready for review August 15, 2019 16:28
@bsclifton bsclifton requested a review from bridiver as a code owner August 15, 2019 16:28
@bsclifton
Copy link
Member Author

Compiled locally and verified this works great 👍

@bsclifton bsclifton mentioned this pull request Aug 21, 2019
Merged
4 tasks
@cezaraugusto @bsclifton
Merge pull request #2973 from brave/ca-4784
a15b76e 
set shields interface views as a global default in settings
kjozwiak
kjozwiak approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.69.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the appropriate issue is moved into the correct milestone.

@bsclifton bsclifton merged commit d80e303 into 0.69.x Aug 28, 2019
@bsclifton bsclifton deleted the pr2973-0.69.x branch August 28, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@cezaraugusto cezaraugusto cezaraugusto left review comments

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
0.69.x-backup
Development

Successfully merging this pull request may close these issues.
3 participants
@bsclifton @cezaraugusto @kjozwiak