Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default shields mode depending on whether it is a new or existing Brave user #5582

Closed
davidtemkin opened this issue Aug 7, 2019 · 1 comment · Fixed by brave/brave-core#3154

Comments

@davidtemkin
Copy link

davidtemkin commented Aug 7, 2019

Test plan

See brave/brave-core#3154

Description

In recent versions of Brave, there is a new "simple" shields view, as well an "advanced" view. The "advanced" view is very similar to the pre-existing single-view version.

In light of that:

  • Existing Brave users should receive the advanced view by default.

  • New Brave users should see the simple view by default (and with one click, they can switch to the advanced view, for all sites).

(IMPORTANT NOTE: The two-mode shields implementation is already in Dev. This particular fix should be uplifted so that by the time the two-mode shields panel hits release, or even Beta, we have already made this change, to keep things familiar for existing users.)

@LaurenWags
Copy link
Member

LaurenWags commented Sep 6, 2019

Verified passed with

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment