Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monthly contributions not reflected on Rewards NTP widget #8467

Closed
LaurenWags opened this issue Feb 28, 2020 · 2 comments · Fixed by brave/brave-core#4801
Closed

monthly contributions not reflected on Rewards NTP widget #8467

LaurenWags opened this issue Feb 28, 2020 · 2 comments · Fixed by brave/brave-core#4801

Comments

@LaurenWags
Copy link
Member

Description

After monthly contributions (recurring tips) have been contributed, they are not reflected on the Rewards NTP widget.

Steps to Reproduce

  1. Launch clean profile from staging with short reconcile interval
  2. Enable Rewards, add BAT to wallet (I tried with both a restored wallet and using a UGP grant)
  3. Do a one time tip, see it reflected in Rewards NTP widget
  4. Set up a recurring tip.
  5. Add sites to AC table, adjust monthly budget if necessary depending on wallet balance.
  6. Wait for reconcile.
  7. Once reconcile is complete, look at Rewards NTP widget.

Actual result:

one time tip and AC are reflected in the widget, but recurring tips are not (bottom number on the widget should be 11, not 10):
Screen Shot 2020-02-28 at 12 58 12 PM

also occurs if you fund via UGP grant instead of restored wallet:
Screen Shot 2020-02-28 at 1 09 36 PM

Expected result:

one time, recurring, and AC should all be reflected in the widget

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.7.26 Chromium: 80.0.3987.122 (Official Build) nightly (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? unsure
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@GeetaSarvadnya
Copy link

Good catch @LaurenWags!

Reproduced in Windows 1.7.26 -Nightly

image

@LaurenWags
Copy link
Member Author

LaurenWags commented Mar 24, 2020

Verified passed with

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-03-24 at 1 46 12 PM

Screen Shot 2020-03-24 at 1 46 00 PM

Verification passed on

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

image

image

Verification passed on

Brave 1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment