Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes recurring tips not being reflected in NTP widget #4801

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 2, 2020

Resolves brave/brave-browser#8467

Submitter Checklist:

Test Plan:

  • start with short reconcile interval
  • claim grant
  • add one time tip
  • add recurring tip and some verified publishers to AC table
  • wait for reconcile to complete
  • go to new tab and make sure that amount is correct now

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Sorry, something went wrong.

@NejcZdovc NejcZdovc added this to the 1.7.x - Nightly milestone Mar 2, 2020
@NejcZdovc NejcZdovc requested a review from a team March 2, 2020 06:48
@NejcZdovc NejcZdovc self-assigned this Mar 2, 2020
@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Mar 2, 2020
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

monthly contributions not reflected on Rewards NTP widget
3 participants