Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News]: Update Brave News Subscribe Icon #16096

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

Resolves brave/brave-browser#26997

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Enable #brave-news-subscribe-button
  2. Button should have an RSS icon, instead of the old <3 icon.

@fallaciousreasoning fallaciousreasoning changed the title [Brave News]: Update Brave News Subscribe Icon: [Brave News]: Update Brave News Subscribe Icon Nov 27, 2022
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@fallaciousreasoning fallaciousreasoning merged commit b410d03 into master Nov 29, 2022
@fallaciousreasoning fallaciousreasoning deleted the bn-subscribe-icon branch November 29, 2022 00:33
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Nov 29, 2022
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.48.13 Chromium: 108.0.5359.62 (Official Build) nightly (x86_64)
Revision 041930a89a990cfab0315a2d9f20d6429a4a67cf-refs/branch-heads/5359@{#938}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. installed 1.48.13
  2. launched Brave
  3. set brave://flags/#brave-news-subscribe-button to Enabled
  4. clicked Relaunch
  5. loaded planet.mozilla.org
  6. changed modes and theme
  7. hovered over the buttons

Confirmed new RSS icon across the following:

Dark mode Dark mode, hover Light mode Light mode, hover purple theme purple theme, hover
Screen Shot 2022-11-28 at 11 05 34 PM Screen Shot 2022-11-28 at 11 05 42 PM Screen Shot 2022-11-28 at 11 06 09 PM Screen Shot 2022-11-28 at 11 06 17 PM Screen Shot 2022-11-28 at 11 06 56 PM Screen Shot 2022-11-28 at 11 07 03 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Brave News]: Update Subscribe Button Icon
3 participants