Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News]: Uplift Subscribe Button Fixes to 1.46.x #16143

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Nov 29, 2022

Fixes brave/brave-browser#26262 (PR #16085)
Fixes brave/brave-browser#26997 (PR #16096)
Fixes brave/brave-browser#26324 (PR #16086) (note the follow up PR replaced the original one)

@kjozwiak
Copy link
Member

As previously discussed, this will go into the 1.46.x maintenance release scheduled for December 14, 2022 as per https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule#release-channel-dates. We'll get this merged into the 1.46.x branch ones 1.46.x goes out on December 1, 2022.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.46.x approved 👍 QA has verified the PR(s) on Nightly as per #16085 (comment), #16096 (comment) & #16086 (comment).

@kjozwiak kjozwiak merged commit 98fb1c8 into 1.46.x Dec 7, 2022
@kjozwiak kjozwiak deleted the bn-subscribe-uplift branch December 7, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants