Alpha #407
Merged
Alpha #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug when currentlyActiveJobsCount = maxJobsToActivate, the client stops polling for new jobs.
fix: polling when maxJobsToActivate is reached in REST Worker
There was a problem hiding this comment.
Pull Request Overview
This PR introduces two main changes:
- In the integration tests, a fixed delay is added before fetching process variables to ensure they are populated.
- In the Camunda job worker, pollLock is explicitly reset when the maximum job capacity is reached.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/operate/operate-integration.spec.ts | Adds a delay (5000ms) in tests to wait for variables to be populated |
| src/c8/lib/CamundaJobWorker.ts | Resets pollLock when at capacity to maintain proper polling state |
Comments suppressed due to low confidence (2)
src/tests/operate/operate-integration.spec.ts:81
- [nitpick] Consider extracting the hardcoded delay (5000ms) into a named constant (or configurable parameter) to improve readability and maintainability.
await new Promise((res) => setTimeout(res, 5000))
src/c8/lib/CamundaJobWorker.ts:168
- [nitpick] Consider adding an inline comment to explain why pollLock is reset here, to clarify the intended control flow when capacity is reached.
this.pollLock = false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR introduces two main changes:
In the integration tests, a fixed delay is added before fetching process variables to ensure they are populated.
In the Camunda job worker, pollLock is explicitly reset when the maximum job capacity is reached.
Type of change
Checklist
alphabranch